From 069d7e5e0576556b9970da10fd97766bc4bea6d2 Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Mon, 3 Oct 2022 12:57:28 +0530 Subject: [PATCH] refactor(common): workaround false-positive `MagicNumber` lint --- .../main/kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt | 2 +- detekt-baselines/common.xml | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/common/src/main/kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt b/common/src/main/kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt index 4b93b400..eb91629c 100644 --- a/common/src/main/kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt +++ b/common/src/main/kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt @@ -180,7 +180,7 @@ fun CommentsButton( badge = { if (commentCount != null) { Badge( - modifier = Modifier.absoluteOffset(x = (-8).dp), + modifier = Modifier.absoluteOffset(x = -(8.dp)), containerColor = MaterialTheme.colorScheme.tertiaryContainer, ) { Text( diff --git a/detekt-baselines/common.xml b/detekt-baselines/common.xml index a738fbf3..3bedeb54 100644 --- a/detekt-baselines/common.xml +++ b/detekt-baselines/common.xml @@ -3,7 +3,6 @@ MagicNumber:CommentEntry.kt$16 - MagicNumber:LobstersCard.kt$8 MagicNumber:Theme.kt$31 ModifierMissing:ClawAppBar.kt$ClawAppBarPreview ModifierReused:LobstersCard.kt$Row( modifier = modifier, verticalAlignment = Alignment.CenterVertically, horizontalArrangement = Arrangement.spacedBy(8.dp), ) { NetworkImage( url = avatarUrl, placeholder = ClawIcons.Account, contentDescription = contentDescription, modifier = modifier.requiredSize(24.dp).clip(CircleShape), ) Text(text = text, modifier = modifier, style = MaterialTheme.typography.bodyMedium) }