feat(build): remove Detekt and switch to Slack's Compose lints

build-logic/build.gradle.kts

@@ -81,7 +81,6 @@ gradlePlugin {
 dependencies {
   implementation(libs.build.agp)
   implementation(libs.build.cachefix)
-  implementation(libs.build.detekt)
   implementation(libs.build.kotlin.gradle)
   implementation(libs.build.semver)
   implementation(libs.build.sentry)

build-logic/src/main/kotlin/dev/msfjarvis/claw/gradle/AndroidCommonPlugin.kt

@@ -18,9 +18,11 @@ import org.gradle.android.AndroidCacheFixPlugin
 import org.gradle.api.JavaVersion
 import org.gradle.api.Plugin
 import org.gradle.api.Project
+import org.gradle.api.artifacts.VersionCatalogsExtension
 import org.gradle.kotlin.dsl.apply
 import org.gradle.kotlin.dsl.configure
 import org.gradle.kotlin.dsl.findByType
+import org.gradle.kotlin.dsl.getByType
 
 class AndroidCommonPlugin : Plugin<Project> {
 
@@ -61,6 +63,9 @@ class AndroidCommonPlugin : Plugin<Project> {
     }
     project.extensions.findByType<ApplicationExtension>()?.run { lint.configureLint(project) }
     project.extensions.findByType<LibraryExtension>()?.run { lint.configureLint(project) }
+    val catalog = project.extensions.getByType<VersionCatalogsExtension>()
+    val libs = catalog.named("libs")
+    project.dependencies.addProvider("lintChecks", libs.findLibrary("slack-compose-lints").get())
   }
 }
 
@@ -69,6 +74,7 @@ private fun Lint.configureLint(project: Project) {
   checkReleaseBuilds = false
   warningsAsErrors = false
   disable.add("DialogFragmentCallbacksDetector")
+  error.add("ComposeM2Api")
   baseline = project.file("lint-baseline.xml")
 }
 

build-logic/src/main/kotlin/dev/msfjarvis/claw/gradle/DependencyUpdatesPlugin.kt

@@ -1,5 +1,5 @@
 /*
- * Copyright © 2022 Harsh Shandilya.
+ * Copyright © 2022-2023 Harsh Shandilya.
  * Use of this source code is governed by an MIT-style
  * license that can be found in the LICENSE file or at
  * https://opensource.org/licenses/MIT.

build-logic/src/main/kotlin/dev/msfjarvis/claw/gradle/Detekt.kt

@@ -1,35 +0,0 @@
-/*
- * Copyright © 2022-2023 Harsh Shandilya.
- * Use of this source code is governed by an MIT-style
- * license that can be found in the LICENSE file or at
- * https://opensource.org/licenses/MIT.
- */
-package dev.msfjarvis.claw.gradle
-
-import io.gitlab.arturbosch.detekt.DetektPlugin
-import io.gitlab.arturbosch.detekt.extensions.DetektExtension
-import org.gradle.api.Project
-import org.gradle.kotlin.dsl.configure
-
-object Detekt {
-  private const val COMPOSE_RULES_VERSION = "0.1.2"
-
-  fun apply(project: Project) {
-    project.pluginManager.apply(DetektPlugin::class.java)
-    project.extensions.configure<DetektExtension> {
-      debug = project.providers.gradleProperty("debugDetekt").isPresent
-      parallel = true
-      ignoredBuildTypes = listOf("benchmark", "release")
-      basePath = project.layout.projectDirectory.toString()
-      baseline =
-        project.rootProject.layout.projectDirectory
-          .dir("detekt-baselines")
-          .file("${project.name}.xml")
-          .asFile
-    }
-    project.dependencies.add(
-      "detektPlugins",
-      "io.nlopez.compose.rules:detekt:$COMPOSE_RULES_VERSION",
-    )
-  }
-}

build-logic/src/main/kotlin/dev/msfjarvis/claw/gradle/KotlinCommonPlugin.kt

@@ -1,5 +1,5 @@
 /*
- * Copyright © 2022 Harsh Shandilya.
+ * Copyright © 2022-2023 Harsh Shandilya.
  * Use of this source code is governed by an MIT-style
  * license that can be found in the LICENSE file or at
  * https://opensource.org/licenses/MIT.
@@ -19,7 +19,6 @@ import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
 class KotlinCommonPlugin : Plugin<Project> {
 
   override fun apply(project: Project) {
-    Detekt.apply(project)
     project.tasks.run {
       withType<JavaCompile>().configureEach {
         sourceCompatibility = JavaVersion.VERSION_11.toString()