msfjarvis/compose-lobsters
1
Fork 0
mirror of https://github.com/msfjarvis/compose-lobsters synced 2025-08-17 10:57:02 +05:30
Code Issues Projects Releases Packages Wiki Activity Actions

Merge #147

Browse source 
147: Better handle tag overflows r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
This commit is contained in:
bors[bot] 2021-03-10 09:22:28 +00:00 • committed by GitHub
commit 17ff1b4217
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

BIN
app/screenshots/debug/dev.msfjarvis.lobsters.ui.posts.HeaderTest_headerDoesNotHaveATransparentBackground.png
View file

Binary file not shown.
Side by side Swipe Overlay

Before

Width:  |  Height:  |  Size: 5.2 KiB

After

Width:  |  Height:  |  Size: 5.2 KiB

Before After
Before After

BIN
app/screenshots/debug/dev.msfjarvis.lobsters.ui.posts.LobstersItemTest_postsAreRenderedCorrectlyOnScreen.png
View file

Binary file not shown.
Side by side Swipe Overlay

Before

Width:  |  Height:  |  Size: 31 KiB

After

Width:  |  Height:  |  Size: 33 KiB

Before After
Before After

10
app/src/main/java/dev/msfjarvis/lobsters/ui/posts/LobstersItem.kt
View file

@ -7,13 +7,10 @@ import androidx.compose.foundation.combinedClickable
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.absoluteOffset
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.requiredSize
import androidx.compose.foundation.layout.requiredWidth
import androidx.compose.foundation.layout.sizeIn
import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.foundation.lazy.items
import androidx.compose.foundation.shape.RoundedCornerShape
@ -67,7 +64,7 @@ fun LobstersItem(
),
) {
Row(
modifier = Modifier.padding(start = 12.dp, end = 12.dp),
modifier = Modifier.padding(start = 12.dp, end = 24.dp),
verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.SpaceBetween,
) {
@ -84,7 +81,7 @@ fun LobstersItem(
TagRow(
tags = post.tags,
modifier = Modifier
.padding(vertical = 8.dp),
.padding(top = 8.dp, bottom = 8.dp, end = 16.dp),
)
Row {
CoilImage(
@ -112,8 +109,7 @@ fun LobstersItem(
checked = isSaved,
onCheckedChange = { onSaveButtonClick.invoke() },
modifier = Modifier
.requiredSize(24.dp)
.absoluteOffset(x = (-24).dp),
.requiredSize(24.dp),
) {
Crossfade(targetState = isSaved) { saved ->
IconResource(