From 227376855669e53747e6b6d3cd3536c255a280fd Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Sat, 28 Oct 2023 00:34:07 +0530 Subject: [PATCH] Revert "fix(api): title and url are required for bookmark edits" Seems to still fail in CI???????????????? This reverts commit cce12fb1380d9f03cee3e4cb35a6fa996eaa8fdd. --- api/src/test/kotlin/dev/msfjarvis/claw/api/ShioriApiTest.kt | 4 ++-- .../kotlin/dev/msfjarvis/claw/model/shiori/EditedBookmark.kt | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/api/src/test/kotlin/dev/msfjarvis/claw/api/ShioriApiTest.kt b/api/src/test/kotlin/dev/msfjarvis/claw/api/ShioriApiTest.kt index 667d6493..8d25a0a0 100644 --- a/api/src/test/kotlin/dev/msfjarvis/claw/api/ShioriApiTest.kt +++ b/api/src/test/kotlin/dev/msfjarvis/claw/api/ShioriApiTest.kt @@ -22,6 +22,7 @@ import org.junit.jupiter.api.AfterAll import org.junit.jupiter.api.AfterEach import org.junit.jupiter.api.BeforeAll import org.junit.jupiter.api.BeforeEach +import org.junit.jupiter.api.Disabled import org.junit.jupiter.api.Test import org.testcontainers.containers.GenericContainer import retrofit2.Retrofit @@ -86,6 +87,7 @@ class ShioriApiTest { } @Test + @Disabled("Server returns HTTP 500, needs debugging") fun editBookmark() = runTest { val response = api.addBookmark( @@ -107,8 +109,6 @@ class ShioriApiTest { val newBookmark = EditedBookmark( id = response.id, - url = response.url, - title = response.title, tags = listOf(Tag("examples")), ) val edited = api.editBookmark(credentials.session, newBookmark) diff --git a/model/src/main/kotlin/dev/msfjarvis/claw/model/shiori/EditedBookmark.kt b/model/src/main/kotlin/dev/msfjarvis/claw/model/shiori/EditedBookmark.kt index c056839e..6f5db401 100644 --- a/model/src/main/kotlin/dev/msfjarvis/claw/model/shiori/EditedBookmark.kt +++ b/model/src/main/kotlin/dev/msfjarvis/claw/model/shiori/EditedBookmark.kt @@ -13,8 +13,8 @@ import kotlinx.serialization.Serializable @Poko class EditedBookmark( val id: Int, - val url: String, - val title: String, + val url: String? = null, + val title: String? = null, val excerpt: String? = null, val author: String? = null, val public: Int? = null,