From 293d12454f96d948b969639ea24f3f96bdb90c9b Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Mon, 3 Oct 2022 11:59:42 +0530 Subject: [PATCH] refactor(common): add a message to preview throwable --- .../main/kotlin/dev/msfjarvis/claw/common/ui/NetworkError.kt | 2 +- detekt-baselines/common.xml | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/common/src/main/kotlin/dev/msfjarvis/claw/common/ui/NetworkError.kt b/common/src/main/kotlin/dev/msfjarvis/claw/common/ui/NetworkError.kt index 7063b1f0..994df49b 100644 --- a/common/src/main/kotlin/dev/msfjarvis/claw/common/ui/NetworkError.kt +++ b/common/src/main/kotlin/dev/msfjarvis/claw/common/ui/NetworkError.kt @@ -67,5 +67,5 @@ fun NetworkError( @ThemePreviews @Composable fun NetworkErrorPreview() { - LobstersTheme { NetworkError(label = "Failed to load posts", error = Throwable()) } + LobstersTheme { NetworkError(label = "Failed to load posts", error = Throwable("Preview")) } } diff --git a/detekt-baselines/common.xml b/detekt-baselines/common.xml index 7a3d81f7..cc22991a 100644 --- a/detekt-baselines/common.xml +++ b/detekt-baselines/common.xml @@ -12,7 +12,6 @@ ModifierReused:LobstersCard.kt$Row( modifier = modifier, verticalAlignment = Alignment.CenterVertically, horizontalArrangement = Arrangement.spacedBy(8.dp), ) { NetworkImage( url = avatarUrl, placeholder = ClawIcons.Account, contentDescription = contentDescription, modifier = modifier.requiredSize(24.dp).clip(CircleShape), ) Text(text = text, modifier = modifier, style = MaterialTheme.typography.bodyMedium) } ModifierReused:LobstersCard.kt$Text(text = text, modifier = modifier, style = MaterialTheme.typography.bodyMedium) SpreadOperator:Theme.kt$(*providedValues) - ThrowingExceptionsWithoutMessageOrCause:NetworkError.kt$Throwable() UnnecessaryAbstractClass:BasePaparazziTest.kt$BasePaparazziTest$BasePaparazziTest