From 301760c39fc439e688bdd6f9d04064c630ae6770 Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Mon, 5 Jun 2023 01:59:02 +0530 Subject: [PATCH] refactor(android): make `String.toLocalDateTime` private --- .../main/kotlin/dev/msfjarvis/claw/android/ui/ext.kt | 12 +----------- .../claw/android/viewmodel/ClawViewModel.kt | 12 +++++++++++- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/ext.kt b/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/ext.kt index c0916a50..38551af7 100644 --- a/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/ext.kt +++ b/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/ext.kt @@ -1,5 +1,5 @@ /* - * Copyright © 2022 Harsh Shandilya. + * Copyright © 2022-2023 Harsh Shandilya. * Use of this source code is governed by an MIT-style * license that can be found in the LICENSE file or at * https://opensource.org/licenses/MIT. @@ -19,8 +19,6 @@ import dev.msfjarvis.claw.common.urllauncher.UrlLauncher import dev.msfjarvis.claw.database.local.SavedPost import dev.msfjarvis.claw.model.LinkMetadata import dev.msfjarvis.claw.model.LobstersPostDetails -import java.time.LocalDateTime -import java.time.format.DateTimeFormatter fun Context.getActivity(): ComponentActivity? { return when (this) { @@ -30,14 +28,6 @@ fun Context.getActivity(): ComponentActivity? { } } -/** - * Parses a given [String] into a [LocalDateTime]. This method is only intended to be used for dates - * in the format returned by the Lobsters API, and is not a general purpose parsing solution. - */ -fun String.toLocalDateTime(): LocalDateTime { - return LocalDateTime.from(DateTimeFormatter.ISO_OFFSET_DATE_TIME.parse(this)) -} - @Composable fun rememberPostActions( urlLauncher: UrlLauncher, diff --git a/android/src/main/kotlin/dev/msfjarvis/claw/android/viewmodel/ClawViewModel.kt b/android/src/main/kotlin/dev/msfjarvis/claw/android/viewmodel/ClawViewModel.kt index c04f0db5..788d7a69 100644 --- a/android/src/main/kotlin/dev/msfjarvis/claw/android/viewmodel/ClawViewModel.kt +++ b/android/src/main/kotlin/dev/msfjarvis/claw/android/viewmodel/ClawViewModel.kt @@ -17,13 +17,14 @@ import dev.msfjarvis.claw.android.injection.IODispatcher import dev.msfjarvis.claw.android.paging.LobstersPagingSource import dev.msfjarvis.claw.android.paging.LobstersPagingSource.Companion.PAGE_SIZE import dev.msfjarvis.claw.android.paging.LobstersPagingSource.Companion.STARTING_PAGE_INDEX -import dev.msfjarvis.claw.android.ui.toLocalDateTime import dev.msfjarvis.claw.api.LobstersApi import dev.msfjarvis.claw.database.local.SavedPost import dev.msfjarvis.claw.model.Comment import java.io.IOException import java.net.HttpURLConnection +import java.time.LocalDateTime import java.time.Month +import java.time.format.DateTimeFormatter import javax.inject.Inject import kotlinx.collections.immutable.ImmutableMap import kotlinx.collections.immutable.toImmutableMap @@ -122,4 +123,13 @@ constructor( is Failure.ApiFailure -> throw IOException("API returned an invalid response") } } + + /** + * Parses a given [String] into a [LocalDateTime]. This method is only intended to be used for + * dates in the format returned by the Lobsters API, and is not a general purpose parsing + * solution. + */ + private fun String.toLocalDateTime(): LocalDateTime { + return LocalDateTime.from(DateTimeFormatter.ISO_OFFSET_DATE_TIME.parse(this)) + } }