msfjarvis/compose-lobsters
1
Fork 0
mirror of https://github.com/msfjarvis/compose-lobsters synced 2025-08-14 14:07:05 +05:30
Code Issues Projects Releases Packages Wiki Activity Actions 3

refactor(common): add missing Modifier parameters

Browse source
This commit is contained in:
Harsh Shandilya 2022-10-03 11:56:59 +05:30
parent 46bfafd681
commit 38f1fdb6a3
No known key found for this signature in database
3 changed files with 11 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

7
common/src/main/kotlin/dev/msfjarvis/claw/common/comments/CommentEntry.kt
View file

@ -49,11 +49,12 @@ import java.time.temporal.TemporalAccessor
fun CommentsHeader( fun CommentsHeader(
postDetails: ExtendedPostDetails, postDetails: ExtendedPostDetails,
postActions: PostActions, postActions: PostActions,
modifier: Modifier = Modifier,
) { ) {
val htmlConverter = LocalHTMLConverter.current val htmlConverter = LocalHTMLConverter.current
val uriHandler = LocalUriHandler.current val uriHandler = LocalUriHandler.current
Surface(color = MaterialTheme.colorScheme.background) { Surface(color = MaterialTheme.colorScheme.background, modifier = modifier) {
Column( Column(
modifier = Modifier.padding(16.dp).fillMaxWidth(), modifier = Modifier.padding(16.dp).fillMaxWidth(),
verticalArrangement = Arrangement.spacedBy(8.dp), verticalArrangement = Arrangement.spacedBy(8.dp),
@ -132,13 +133,15 @@ fun PostLink(
@Composable @Composable
fun CommentEntry( fun CommentEntry(
comment: Comment, comment: Comment,
modifier: Modifier = Modifier,
) { ) {
var expanded by remember(comment) { mutableStateOf(true) } var expanded by remember(comment) { mutableStateOf(true) }
val htmlConverter = LocalHTMLConverter.current val htmlConverter = LocalHTMLConverter.current
val uriHandler = LocalUriHandler.current val uriHandler = LocalUriHandler.current
Box( Box(
modifier = modifier =
Modifier.fillMaxWidth() modifier
.fillMaxWidth()
.clickable { expanded = !expanded } .clickable { expanded = !expanded }
.background(MaterialTheme.colorScheme.background) .background(MaterialTheme.colorScheme.background)
.padding(start = (comment.indentLevel * 16).dp, end = 16.dp, top = 16.dp, bottom = 16.dp), .padding(start = (comment.indentLevel * 16).dp, end = 16.dp, top = 16.dp, bottom = 16.dp),

8
common/src/main/kotlin/dev/msfjarvis/claw/common/ui/decorations/MonthHeader.kt
View file

@ -19,9 +19,13 @@ import dev.msfjarvis.claw.common.ui.surfaceColorAtNavigationBarElevation
import java.time.Month import java.time.Month
@Composable @Composable
fun MonthHeader(month: Month) { fun MonthHeader(
month: Month,
modifier: Modifier = Modifier,
) {
Box( Box(
Modifier.fillMaxWidth() modifier
.fillMaxWidth()
.wrapContentHeight() .wrapContentHeight()
.background(MaterialTheme.colorScheme.surfaceColorAtNavigationBarElevation()) .background(MaterialTheme.colorScheme.surfaceColorAtNavigationBarElevation())
) { ) {

3
detekt-baselines/common.xml
View file

@ -9,9 +9,6 @@
<ID>MagicNumber:LobstersCard.kt$8</ID> <ID>MagicNumber:LobstersCard.kt$8</ID>
<ID>MagicNumber:Theme.kt$31</ID> <ID>MagicNumber:Theme.kt$31</ID>
<ID>ModifierMissing:ClawAppBar.kt$ClawAppBarPreview</ID> <ID>ModifierMissing:ClawAppBar.kt$ClawAppBarPreview</ID>
<ID>ModifierMissing:CommentEntry.kt$CommentEntry</ID>
<ID>ModifierMissing:CommentEntry.kt$CommentsHeader</ID>
<ID>ModifierMissing:MonthHeader.kt$MonthHeader</ID>
<ID>ModifierReused:LobstersCard.kt$Row( modifier = modifier, verticalAlignment = Alignment.CenterVertically, horizontalArrangement = Arrangement.spacedBy(8.dp), ) { NetworkImage( url = avatarUrl, placeholder = ClawIcons.Account, contentDescription = contentDescription, modifier = modifier.requiredSize(24.dp).clip(CircleShape), ) Text(text = text, modifier = modifier, style = MaterialTheme.typography.bodyMedium) }</ID> <ID>ModifierReused:LobstersCard.kt$Row( modifier = modifier, verticalAlignment = Alignment.CenterVertically, horizontalArrangement = Arrangement.spacedBy(8.dp), ) { NetworkImage( url = avatarUrl, placeholder = ClawIcons.Account, contentDescription = contentDescription, modifier = modifier.requiredSize(24.dp).clip(CircleShape), ) Text(text = text, modifier = modifier, style = MaterialTheme.typography.bodyMedium) }</ID>
<ID>ModifierReused:LobstersCard.kt$Text(text = text, modifier = modifier, style = MaterialTheme.typography.bodyMedium)</ID> <ID>ModifierReused:LobstersCard.kt$Text(text = text, modifier = modifier, style = MaterialTheme.typography.bodyMedium)</ID>
<ID>SpreadOperator:Theme.kt$(*providedValues)</ID> <ID>SpreadOperator:Theme.kt$(*providedValues)</ID>