From 4b4f00ad8e0aea63f6d7bcf1da8674c364990c0d Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Wed, 30 Aug 2023 15:06:34 +0530 Subject: [PATCH] feat(android): enable read posts feature --- CHANGELOG.md | 1 + android/build.gradle.kts | 10 ---------- .../main/kotlin/dev/msfjarvis/claw/android/ui/ext.kt | 9 ++------- 3 files changed, 3 insertions(+), 17 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d8390c05..0590d186 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Added * Add a swipe action on each story to open the comments page on `lobste.rs` +* Automatically mark posts as "read" and visually distinguish between them ### Changed diff --git a/android/build.gradle.kts b/android/build.gradle.kts index 317d5536..caae4f45 100644 --- a/android/build.gradle.kts +++ b/android/build.gradle.kts @@ -6,7 +6,6 @@ */ @file:Suppress("UnstableApiUsage") -import com.android.build.api.variant.BuildConfigField import dev.msfjarvis.claw.gradle.addTestDependencies plugins { @@ -35,15 +34,6 @@ android { packagingOptions.resources.pickFirsts += "**/*.bin" } -androidComponents { - onVariants { variant -> - variant.buildConfigFields.put( - "ENABLE_READ_COMMENTS", - BuildConfigField("boolean", "false", "Not yet buddy boy") - ) - } -} - baselineProfile { dexLayoutOptimization = true mergeIntoMain = true diff --git a/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/ext.kt b/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/ext.kt index e95c43d5..b0f32422 100644 --- a/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/ext.kt +++ b/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/ext.kt @@ -12,7 +12,6 @@ import androidx.activity.ComponentActivity import androidx.compose.runtime.Composable import androidx.compose.runtime.remember import androidx.navigation.NavController -import dev.msfjarvis.claw.android.BuildConfig import dev.msfjarvis.claw.android.ui.navigation.Destinations import dev.msfjarvis.claw.android.viewmodel.ClawViewModel import dev.msfjarvis.claw.common.posts.PostActions @@ -38,16 +37,12 @@ fun rememberPostActions( return remember { object : PostActions { override fun viewPost(postId: String, postUrl: String, commentsUrl: String) { - if (BuildConfig.ENABLE_READ_COMMENTS) { - viewModel.markPostAsRead(postId) - } + viewModel.markPostAsRead(postId) urlLauncher.openUri(postUrl.ifEmpty { commentsUrl }) } override fun viewComments(postId: String) { - if (BuildConfig.ENABLE_READ_COMMENTS) { - viewModel.markPostAsRead(postId) - } + viewModel.markPostAsRead(postId) val currentRoute = navController.currentDestination?.route val newRoute = Destinations.Comments.route.replace(Destinations.Comments.placeholder, postId)