msfjarvis/compose-lobsters
1
Fork 0
mirror of https://github.com/msfjarvis/compose-lobsters synced 2025-08-14 17:37:05 +05:30
Code Issues Projects Releases Packages Wiki Activity Actions 4

android: avoid coroutine launch in composition context

Browse source
This commit is contained in:
Harsh Shandilya 2021-10-25 00:48:33 +05:30
parent cfd0725605
commit 53905c80de
No known key found for this signature in database
GPG key ID: 366D7BBAD1031E80
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
android/src/main/kotlin/dev/msfjarvis/claw/android/ui/NetworkPosts.kt
View file

@ -4,10 +4,10 @@ import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.lazy.LazyColumn import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.foundation.lazy.LazyListState import androidx.compose.foundation.lazy.LazyListState
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.getValue import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember import androidx.compose.runtime.remember
import androidx.compose.runtime.rememberCoroutineScope
import androidx.compose.runtime.setValue import androidx.compose.runtime.setValue
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.unit.dp import androidx.compose.ui.unit.dp
@ -18,7 +18,6 @@ import dev.msfjarvis.claw.common.posts.PostActions
import dev.msfjarvis.claw.common.posts.toDbModel import dev.msfjarvis.claw.common.posts.toDbModel
import dev.msfjarvis.claw.database.local.SavedPost import dev.msfjarvis.claw.database.local.SavedPost
import dev.msfjarvis.claw.model.LobstersPost import dev.msfjarvis.claw.model.LobstersPost
import kotlinx.coroutines.launch
@Composable @Composable
fun NetworkPosts( fun NetworkPosts(
@ -28,7 +27,6 @@ fun NetworkPosts(
postActions: PostActions, postActions: PostActions,
modifier: Modifier = Modifier, modifier: Modifier = Modifier,
) { ) {
val coroutineScope = rememberCoroutineScope()
LazyColumn( LazyColumn(
state = listState, state = listState,
modifier = modifier, modifier = modifier,
@ -37,7 +35,7 @@ fun NetworkPosts(
if (item != null) { if (item != null) {
val dbModel = item.toDbModel() val dbModel = item.toDbModel()
var saved by remember(dbModel) { mutableStateOf(false) } var saved by remember(dbModel) { mutableStateOf(false) }
coroutineScope.launch { saved = isSaved(dbModel) } LaunchedEffect(dbModel) { saved = isSaved(dbModel) }
LobstersCard( LobstersCard(
post = dbModel, post = dbModel,
isSaved = saved, isSaved = saved,