From 5678215b25c26c62a4a8d581b5ceda25da27e303 Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Mon, 9 Nov 2020 11:45:05 +0530 Subject: [PATCH] Tweak lambda parameters for LobstersItem Signed-off-by: Harsh Shandilya --- .../msfjarvis/lobsters/ui/posts/HottestPosts.kt | 6 +++--- .../msfjarvis/lobsters/ui/posts/LobstersItem.kt | 15 +++++++++------ .../dev/msfjarvis/lobsters/ui/posts/SavedPosts.kt | 6 +++--- 3 files changed, 15 insertions(+), 12 deletions(-) diff --git a/app/src/main/java/dev/msfjarvis/lobsters/ui/posts/HottestPosts.kt b/app/src/main/java/dev/msfjarvis/lobsters/ui/posts/HottestPosts.kt index ad5afa9e..071b62c6 100644 --- a/app/src/main/java/dev/msfjarvis/lobsters/ui/posts/HottestPosts.kt +++ b/app/src/main/java/dev/msfjarvis/lobsters/ui/posts/HottestPosts.kt @@ -32,9 +32,9 @@ fun HottestPosts( } LobstersItem( post = item, - onClick = { post -> urlLauncher.launch(post.url.ifEmpty { post.commentsUrl }) }, - onLongClick = { post -> urlLauncher.launch(post.commentsUrl) }, - onSaveButtonClick = saveAction, + onClick = { urlLauncher.launch(item.url.ifEmpty { item.commentsUrl }) }, + onLongClick = { urlLauncher.launch(item.commentsUrl) }, + onSaveButtonClick = { saveAction.invoke(item) }, ) } } diff --git a/app/src/main/java/dev/msfjarvis/lobsters/ui/posts/LobstersItem.kt b/app/src/main/java/dev/msfjarvis/lobsters/ui/posts/LobstersItem.kt index 0e8c4756..626ed04d 100644 --- a/app/src/main/java/dev/msfjarvis/lobsters/ui/posts/LobstersItem.kt +++ b/app/src/main/java/dev/msfjarvis/lobsters/ui/posts/LobstersItem.kt @@ -58,15 +58,15 @@ val TEST_POST = LobstersPost( @Composable fun LobstersItem( post: LobstersPost, - onClick: (LobstersPost) -> Unit = {}, - onLongClick: (LobstersPost) -> Unit = {}, - onSaveButtonClick: (LobstersPost) -> Unit = {}, + onClick: () -> Unit, + onLongClick: () -> Unit, + onSaveButtonClick: () -> Unit, ) { Surface( modifier = Modifier.fillMaxWidth() .clickable( - onClick = { onClick.invoke(post) }, - onLongClick = { onLongClick.invoke(post) }, + onClick = onClick, + onLongClick = onLongClick, ), ) { ConstraintLayout( @@ -112,7 +112,7 @@ fun LobstersItem( resourceId = R.drawable.ic_favorite_border_24px, modifier = Modifier.padding(8.dp) .clickable( - onClick = { onSaveButtonClick.invoke(post) }, + onClick = onSaveButtonClick, indication = RippleIndication(), ) .constrainAs(saveButton) { @@ -153,6 +153,9 @@ fun Preview() { LazyColumnFor(items = listOf(TEST_POST, TEST_POST, TEST_POST, TEST_POST, TEST_POST)) { item -> LobstersItem( post = item, + onClick = {}, + onLongClick = {}, + onSaveButtonClick = {}, ) } } diff --git a/app/src/main/java/dev/msfjarvis/lobsters/ui/posts/SavedPosts.kt b/app/src/main/java/dev/msfjarvis/lobsters/ui/posts/SavedPosts.kt index 30bd941a..1bf4537f 100644 --- a/app/src/main/java/dev/msfjarvis/lobsters/ui/posts/SavedPosts.kt +++ b/app/src/main/java/dev/msfjarvis/lobsters/ui/posts/SavedPosts.kt @@ -28,9 +28,9 @@ fun SavedPosts( ) { item -> LobstersItem( post = item, - onClick = { post -> urlLauncher.launch(post.url.ifEmpty { post.commentsUrl }) }, - onLongClick = { post -> urlLauncher.launch(post.commentsUrl) }, - onSaveButtonClick = saveAction, + onClick = { urlLauncher.launch(item.url.ifEmpty { item.commentsUrl }) }, + onLongClick = { urlLauncher.launch(item.commentsUrl) }, + onSaveButtonClick = { saveAction.invoke(item) }, ) } }