From 5a098e125a590548fc7f21a41fc132d806336bf6 Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Sun, 28 May 2023 13:39:39 +0530 Subject: [PATCH] Apply suggestions from code review --- .../main/kotlin/dev/msfjarvis/claw/android/ui/LobstersApp.kt | 2 +- .../dev/msfjarvis/claw/android/ui/navigation/NavigationType.kt | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/LobstersApp.kt b/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/LobstersApp.kt index d7e12935..42263d0e 100644 --- a/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/LobstersApp.kt +++ b/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/LobstersApp.kt @@ -160,7 +160,7 @@ fun LobstersApp( modifier = modifier.semantics { testTagsAsResourceId = true }, ) { paddingValues -> Row(modifier = Modifier.padding(paddingValues)) { - AnimatedVisibility(visible = navigationType != ClawNavigationType.BOTTOM_NAVIGATION) { + AnimatedVisibility(visible = navigationType == ClawNavigationType.NAVIGATION_RAIL) { ClawNavigationRail( navController = navController, items = navItems, diff --git a/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/navigation/NavigationType.kt b/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/navigation/NavigationType.kt index 1602fe80..4caa080a 100644 --- a/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/navigation/NavigationType.kt +++ b/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/navigation/NavigationType.kt @@ -15,7 +15,6 @@ enum class ClawNavigationType { companion object { fun fromSize(windowSize: WindowWidthSizeClass): ClawNavigationType { return when (windowSize) { - WindowWidthSizeClass.Compact -> BOTTOM_NAVIGATION WindowWidthSizeClass.Medium, WindowWidthSizeClass.Expanded -> NAVIGATION_RAIL else -> BOTTOM_NAVIGATION