From 687cb32f7cd2fe48ab3f0dcafda108f217f4194f Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Wed, 24 Apr 2024 23:44:13 +0530 Subject: [PATCH] fix: remove visual divider --- CHANGELOG.md | 4 ++++ .../dev/msfjarvis/claw/android/ui/lists/DatabasePosts.kt | 2 -- .../dev/msfjarvis/claw/android/ui/lists/NetworkPosts.kt | 2 -- .../kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d333dd95..be75f676 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Changed + +- Remove dividers between posts + ### Fixed - Disable logging of network errors to Sentry diff --git a/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/lists/DatabasePosts.kt b/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/lists/DatabasePosts.kt index 7a62df20..bd877ce4 100644 --- a/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/lists/DatabasePosts.kt +++ b/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/lists/DatabasePosts.kt @@ -17,7 +17,6 @@ import androidx.compose.foundation.lazy.LazyListState import androidx.compose.foundation.lazy.items import androidx.compose.material.icons.Icons import androidx.compose.material.icons.filled.Inbox -import androidx.compose.material3.HorizontalDivider import androidx.compose.material3.Icon import androidx.compose.material3.MaterialTheme import androidx.compose.material3.Text @@ -55,7 +54,6 @@ fun DatabasePosts( stickyHeader(contentType = "month-header") { MonthHeader(label = month) } items(items = posts, key = { it.shortId }, contentType = { "LobstersItem" }) { item -> LobstersListItem(item = item, refresh = {}, postActions = postActions) - HorizontalDivider() } } } diff --git a/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/lists/NetworkPosts.kt b/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/lists/NetworkPosts.kt index 486664e4..5448c033 100644 --- a/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/lists/NetworkPosts.kt +++ b/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/lists/NetworkPosts.kt @@ -16,7 +16,6 @@ import androidx.compose.foundation.lazy.LazyColumn import androidx.compose.foundation.lazy.LazyListState import androidx.compose.foundation.lazy.rememberLazyListState import androidx.compose.material3.ExperimentalMaterial3Api -import androidx.compose.material3.HorizontalDivider import androidx.compose.runtime.Composable import androidx.compose.ui.Alignment import androidx.compose.ui.Modifier @@ -73,7 +72,6 @@ fun NetworkPosts( postActions = postActions, refresh = { lazyPagingItems.refresh() }, ) - HorizontalDivider() } } if (lazyPagingItems.loadState.append == LoadState.Loading) { diff --git a/common/src/main/kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt b/common/src/main/kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt index 8aa76673..a5a56aa6 100644 --- a/common/src/main/kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt +++ b/common/src/main/kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt @@ -76,7 +76,7 @@ fun LobstersCard( refresh() } .background(MaterialTheme.colorScheme.background) - .padding(start = 8.dp) + .padding(start = 8.dp, bottom = 2.dp) ) { Row( horizontalArrangement = Arrangement.spacedBy(8.dp),