From 6ee00f6a27764650a8930dfb88099e87177b0686 Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Thu, 6 Oct 2022 11:43:54 +0530 Subject: [PATCH] refactor(build-logic): cleanup Detekt issues --- .../kotlin/dev/msfjarvis/aps/gradle/ApplicationPlugin.kt | 8 -------- .../dev/msfjarvis/aps/gradle/artifacts/CollectApksTask.kt | 2 +- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/build-logic/android-plugins/src/main/kotlin/dev/msfjarvis/aps/gradle/ApplicationPlugin.kt b/build-logic/android-plugins/src/main/kotlin/dev/msfjarvis/aps/gradle/ApplicationPlugin.kt index c44b40d5..161e83e3 100644 --- a/build-logic/android-plugins/src/main/kotlin/dev/msfjarvis/aps/gradle/ApplicationPlugin.kt +++ b/build-logic/android-plugins/src/main/kotlin/dev/msfjarvis/aps/gradle/ApplicationPlugin.kt @@ -50,12 +50,4 @@ class ApplicationPlugin : Plugin { project.configureBuildSigning() } } - - private fun Project.isSnapshot(): Boolean { - with(project.providers) { - val workflow = environmentVariable("GITHUB_WORKFLOW") - val snapshot = environmentVariable("SNAPSHOT") - return workflow.isPresent || snapshot.isPresent - } - } } diff --git a/build-logic/android-plugins/src/main/kotlin/dev/msfjarvis/aps/gradle/artifacts/CollectApksTask.kt b/build-logic/android-plugins/src/main/kotlin/dev/msfjarvis/aps/gradle/artifacts/CollectApksTask.kt index 7d71671d..4af18fac 100644 --- a/build-logic/android-plugins/src/main/kotlin/dev/msfjarvis/aps/gradle/artifacts/CollectApksTask.kt +++ b/build-logic/android-plugins/src/main/kotlin/dev/msfjarvis/aps/gradle/artifacts/CollectApksTask.kt @@ -32,7 +32,7 @@ abstract class CollectApksTask : DefaultTask() { val outputDir = outputDirectory.asFile.get() outputDir.mkdirs() val builtArtifacts = - builtArtifactsLoader.get().load(apkFolder.get()) ?: throw RuntimeException("Cannot load APKs") + builtArtifactsLoader.get().load(apkFolder.get()) ?: error("Cannot load APKs") builtArtifacts.elements.forEach { artifact -> Files.copy( Paths.get(artifact.outputFile),