From b455724b1cdeab2f71f06864a46b26a1688a30e3 Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Sun, 14 Feb 2021 18:05:23 +0530 Subject: [PATCH 1/2] build: cleanup Plugin declarations Signed-off-by: Harsh Shandilya --- buildSrc/build.gradle.kts | 10 +++++----- buildSrc/src/main/java/Dependencies.kt | 11 +++++------ 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/buildSrc/build.gradle.kts b/buildSrc/build.gradle.kts index d47bc94e..ac32817f 100644 --- a/buildSrc/build.gradle.kts +++ b/buildSrc/build.gradle.kts @@ -29,10 +29,10 @@ gradlePlugin { } dependencies { - implementation(Plugins.androidGradlePlugin) - implementation(Plugins.androidGradlePlugin_lintModel) - implementation(Plugins.daggerGradlePlugin) + implementation(Plugins.android) + implementation(Plugins.hilt) implementation(Plugins.jsemver) - implementation(Plugins.kotlinGradlePlugin) - implementation(Plugins.sqldelightGradlePlugin) + implementation(Plugins.lintModel) + implementation(Plugins.kotlin) + implementation(Plugins.sqldelight) } diff --git a/buildSrc/src/main/java/Dependencies.kt b/buildSrc/src/main/java/Dependencies.kt index d93e124c..39bdca41 100644 --- a/buildSrc/src/main/java/Dependencies.kt +++ b/buildSrc/src/main/java/Dependencies.kt @@ -6,13 +6,12 @@ private const val DAGGER_HILT_VERSION = "2.32-alpha" object Plugins { - const val androidGradlePlugin = "com.android.tools.build:gradle:7.0.0-alpha06" - const val androidGradlePlugin_lintModel = "com.android.tools.lint:lint-model:30.0.0-alpha06" - const val daggerGradlePlugin = - "com.google.dagger:hilt-android-gradle-plugin:${DAGGER_HILT_VERSION}" - const val kotlinGradlePlugin = "org.jetbrains.kotlin:kotlin-gradle-plugin:1.4.30" + const val android = "com.android.tools.build:gradle:7.0.0-alpha06" + const val lintModel = "com.android.tools.lint:lint-model:30.0.0-alpha06" + const val hilt = "com.google.dagger:hilt-android-gradle-plugin:${DAGGER_HILT_VERSION}" + const val kotlin = "org.jetbrains.kotlin:kotlin-gradle-plugin:1.4.30" const val jsemver = "com.github.zafarkhaja:java-semver:0.9.0" - const val sqldelightGradlePlugin = "com.squareup.sqldelight:gradle-plugin:1.4.4" + const val sqldelight = "com.squareup.sqldelight:gradle-plugin:1.4.4" } object Dependencies { From f30fd727781c21d00a1705e1380fb71c621d563d Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Sun, 14 Feb 2021 18:05:59 +0530 Subject: [PATCH 2/2] app: remove unused methods Signed-off-by: Harsh Shandilya --- .../msfjarvis/lobsters/data/repo/LobstersRepository.kt | 8 -------- 1 file changed, 8 deletions(-) diff --git a/app/src/main/java/dev/msfjarvis/lobsters/data/repo/LobstersRepository.kt b/app/src/main/java/dev/msfjarvis/lobsters/data/repo/LobstersRepository.kt index a9ff9f68..18e6f5c9 100644 --- a/app/src/main/java/dev/msfjarvis/lobsters/data/repo/LobstersRepository.kt +++ b/app/src/main/java/dev/msfjarvis/lobsters/data/repo/LobstersRepository.kt @@ -21,10 +21,6 @@ class LobstersRepository constructor( return savedPostsCache.containsKey(postId) } - fun getPostFromCache(postId: String): LobstersPost? { - return savedPostsCache[postId] - } - fun getAllPostsFromCache(): List { return savedPostsCache.values.toList() } @@ -43,10 +39,6 @@ class LobstersRepository constructor( _isCacheReady.value = true } - private suspend fun getPost(postId: String): LobstersPost? = withContext(Dispatchers.IO) { - return@withContext lobstersDatabase.postQueries.selectPost(postId).executeAsOneOrNull() - } - private suspend fun getAllPosts(): List = withContext(Dispatchers.IO) { return@withContext lobstersDatabase.postQueries.selectAllPosts().executeAsList() }