From 786f67404448b64f7f6ecd0ab587df8a996258b3 Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Wed, 2 Aug 2023 01:40:16 +0530 Subject: [PATCH] fix(api): make commentsUrl in search results absolute --- .../dev/msfjarvis/claw/api/converters/SearchConverter.kt | 2 +- api/src/test/kotlin/dev/msfjarvis/claw/api/SearchApiTest.kt | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/api/src/main/kotlin/dev/msfjarvis/claw/api/converters/SearchConverter.kt b/api/src/main/kotlin/dev/msfjarvis/claw/api/converters/SearchConverter.kt index ef6e2560..7bd429cf 100644 --- a/api/src/main/kotlin/dev/msfjarvis/claw/api/converters/SearchConverter.kt +++ b/api/src/main/kotlin/dev/msfjarvis/claw/api/converters/SearchConverter.kt @@ -51,7 +51,7 @@ object SearchConverter : Converter> { private fun getCommentsData(elem: Elements): Pair { val linkElement = elem.select("a") val countString = linkElement.text().trimStart().substringBefore(" ") - val commentsUrl = linkElement.attr("href") + val commentsUrl = LobstersApi.BASE_URL + linkElement.attr("href") return (countString.toIntOrNull() ?: 0) to commentsUrl } diff --git a/api/src/test/kotlin/dev/msfjarvis/claw/api/SearchApiTest.kt b/api/src/test/kotlin/dev/msfjarvis/claw/api/SearchApiTest.kt index 5a1777d9..5b5dc8af 100644 --- a/api/src/test/kotlin/dev/msfjarvis/claw/api/SearchApiTest.kt +++ b/api/src/test/kotlin/dev/msfjarvis/claw/api/SearchApiTest.kt @@ -37,7 +37,7 @@ class SearchApiTest { url = "https://xenodium.com/chatgpt-visits-the-emacs-doctor/", createdAt = "", commentCount = 3, - commentsUrl = "/s/gjlsdg/chatgpt_visits_emacs_doctor", + commentsUrl = "https://lobste.rs/s/gjlsdg/chatgpt_visits_emacs_doctor", submitter = User("xenodium", "", null, "/avatars/xenodium-16.png", ""), tags = listOf("ai", "emacs"), description = "", @@ -49,7 +49,7 @@ class SearchApiTest { url = "https://mstack.nl/blog/20230623-chatgpt-question-pdf-document/", createdAt = "", commentCount = 0, - commentsUrl = "/s/astcqf/implementing_question_answering_system", + commentsUrl = "https://lobste.rs/s/astcqf/implementing_question_answering_system", submitter = User("asteroid", "", null, "/avatars/asteroid-16.png", ""), tags = listOf("ai"), description = "",