msfjarvis/compose-lobsters
1
Fork 0
mirror of https://github.com/msfjarvis/compose-lobsters synced 2025-08-14 22:17:03 +05:30
Code Issues Projects Releases Packages Wiki Activity Actions 4

refactor: remove unnecessary clickable configuration

Browse source
This commit is contained in:
Harsh Shandilya 2022-11-28 12:57:02 +05:30
parent e12fc5ae6a
commit 84e09fd5e1
No known key found for this signature in database
1 changed files with 1 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

10
common/src/main/kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt
View file

@ -11,7 +11,6 @@ import androidx.compose.foundation.ExperimentalFoundationApi
import androidx.compose.foundation.background import androidx.compose.foundation.background
import androidx.compose.foundation.clickable import androidx.compose.foundation.clickable
import androidx.compose.foundation.combinedClickable import androidx.compose.foundation.combinedClickable
import androidx.compose.foundation.interaction.MutableInteractionSource
import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column import androidx.compose.foundation.layout.Column
@ -25,7 +24,6 @@ import androidx.compose.foundation.layout.requiredSize
import androidx.compose.foundation.layout.width import androidx.compose.foundation.layout.width
import androidx.compose.foundation.layout.wrapContentHeight import androidx.compose.foundation.layout.wrapContentHeight
import androidx.compose.foundation.shape.CircleShape import androidx.compose.foundation.shape.CircleShape
import androidx.compose.material.ripple.rememberRipple
import androidx.compose.material3.Badge import androidx.compose.material3.Badge
import androidx.compose.material3.BadgedBox import androidx.compose.material3.BadgedBox
import androidx.compose.material3.Divider import androidx.compose.material3.Divider
@ -82,11 +80,7 @@ fun LobstersCard(
SaveButton( SaveButton(
isSaved = localSavedState, isSaved = localSavedState,
modifier = modifier =
Modifier.clickable( Modifier.clickable(role = Role.Button) {
role = Role.Button,
indication = rememberRipple(bounded = false, radius = 24.dp),
interactionSource = remember { MutableInteractionSource() },
) {
localSavedState = !localSavedState localSavedState = !localSavedState
postActions.toggleSave(post) postActions.toggleSave(post)
}, },
@ -97,8 +91,6 @@ fun LobstersCard(
modifier = modifier =
Modifier.combinedClickable( Modifier.combinedClickable(
role = Role.Button, role = Role.Button,
indication = rememberRipple(bounded = false, radius = 24.dp),
interactionSource = remember { MutableInteractionSource() },
onClick = { postActions.viewComments(post.shortId) }, onClick = { postActions.viewComments(post.shortId) },
onLongClick = { postActions.viewCommentsPage(post.commentsUrl) }, onLongClick = { postActions.viewCommentsPage(post.commentsUrl) },
), ),