From 8f927613f3b2f9edd1929e764f07a79105b3de4c Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Mon, 3 Oct 2022 12:53:32 +0530 Subject: [PATCH] refactor(common): correctly use modifier in `TagText` --- .../kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt | 7 +++---- detekt-baselines/common.xml | 1 - 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/common/src/main/kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt b/common/src/main/kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt index bcdc7cd5..4b93b400 100644 --- a/common/src/main/kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt +++ b/common/src/main/kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt @@ -19,7 +19,6 @@ import androidx.compose.foundation.layout.requiredSize import androidx.compose.foundation.layout.width import androidx.compose.foundation.layout.wrapContentHeight import androidx.compose.foundation.shape.CircleShape -import androidx.compose.foundation.shape.RoundedCornerShape import androidx.compose.material.ripple.rememberRipple import androidx.compose.material3.Badge import androidx.compose.material3.BadgedBox @@ -224,9 +223,9 @@ fun TagText( Text( text = tag, modifier = - Modifier.background(MaterialTheme.colorScheme.tertiaryContainer, RoundedCornerShape(50)) - .padding(vertical = 4.dp, horizontal = 12.dp) - .then(modifier), + modifier + .background(MaterialTheme.colorScheme.tertiaryContainer, CircleShape) + .padding(vertical = 4.dp, horizontal = 12.dp), color = MaterialTheme.colorScheme.onTertiaryContainer, style = MaterialTheme.typography.labelLarge, ) diff --git a/detekt-baselines/common.xml b/detekt-baselines/common.xml index e257e2f3..a738fbf3 100644 --- a/detekt-baselines/common.xml +++ b/detekt-baselines/common.xml @@ -3,7 +3,6 @@ MagicNumber:CommentEntry.kt$16 - MagicNumber:LobstersCard.kt$50 MagicNumber:LobstersCard.kt$8 MagicNumber:Theme.kt$31 ModifierMissing:ClawAppBar.kt$ClawAppBarPreview