Merge #97

97: Resolve a couple Lint issues r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>

app/src/main/AndroidManifest.xml

@@ -9,7 +9,7 @@
     android:allowBackup="true"
     android:icon="@mipmap/ic_launcher"
     android:label="@string/app_name"
-    android:roundIcon="@mipmap/ic_launcher_round"
+    android:roundIcon="@mipmap/ic_launcher"
     android:supportsRtl="true"
     android:theme="@style/Theme.AppCompat.DayNight">
     <activity

app/src/main/java/dev/msfjarvis/lobsters/ui/main/MainActivity.kt

@@ -32,7 +32,7 @@ import dev.msfjarvis.lobsters.ui.posts.HottestPosts
 import dev.msfjarvis.lobsters.ui.posts.SavedPosts
 import dev.msfjarvis.lobsters.ui.theme.LobstersTheme
 import dev.msfjarvis.lobsters.ui.urllauncher.UrlLauncher
-import dev.msfjarvis.lobsters.ui.urllauncher.UrlLauncherAmbient
+import dev.msfjarvis.lobsters.ui.urllauncher.AmbientUrlLauncher
 import dev.msfjarvis.lobsters.ui.viewmodel.LobstersViewModel
 import dev.msfjarvis.lobsters.util.IconResource
 import kotlinx.coroutines.CoroutineScope
@@ -46,7 +46,7 @@ class MainActivity : AppCompatActivity() {
   override fun onCreate(savedInstanceState: Bundle?) {
     super.onCreate(savedInstanceState)
     setContent {
-      Providers(UrlLauncherAmbient provides urlLauncher) {
+      Providers(AmbientUrlLauncher provides urlLauncher) {
         LobstersTheme {
           LobstersApp()
         }

app/src/main/java/dev/msfjarvis/lobsters/ui/posts/HottestPosts.kt

@@ -8,7 +8,7 @@ import androidx.paging.LoadState
 import androidx.paging.compose.LazyPagingItems
 import androidx.paging.compose.items
 import dev.msfjarvis.lobsters.model.LobstersPost
-import dev.msfjarvis.lobsters.ui.urllauncher.UrlLauncherAmbient
+import dev.msfjarvis.lobsters.ui.urllauncher.AmbientUrlLauncher
 
 @Composable
 fun HottestPosts(
@@ -17,7 +17,7 @@ fun HottestPosts(
   modifier: Modifier = Modifier,
   saveAction: (LobstersPost) -> Unit,
 ) {
-  val urlLauncher = UrlLauncherAmbient.current
+  val urlLauncher = AmbientUrlLauncher.current
 
   if (posts.loadState.refresh == LoadState.Loading) {
     EmptyList(saved = false)

app/src/main/java/dev/msfjarvis/lobsters/ui/posts/SavedPosts.kt

@@ -5,7 +5,7 @@ import androidx.compose.foundation.lazy.rememberLazyListState
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
 import dev.msfjarvis.lobsters.model.LobstersPost
-import dev.msfjarvis.lobsters.ui.urllauncher.UrlLauncherAmbient
+import dev.msfjarvis.lobsters.ui.urllauncher.AmbientUrlLauncher
 
 @Composable
 fun SavedPosts(
@@ -14,7 +14,7 @@ fun SavedPosts(
   saveAction: (LobstersPost) -> Unit,
 ) {
   val listState = rememberLazyListState()
-  val urlLauncher = UrlLauncherAmbient.current
+  val urlLauncher = AmbientUrlLauncher.current
 
   if (posts.isEmpty()) {
     EmptyList(saved = true)

app/src/main/java/dev/msfjarvis/lobsters/ui/urllauncher/AmbientUrlLauncher.kt

@@ -2,4 +2,4 @@ package dev.msfjarvis.lobsters.ui.urllauncher
 
 import androidx.compose.runtime.staticAmbientOf
 
-val UrlLauncherAmbient = staticAmbientOf<UrlLauncher> { error("Needs to be provided") }
+val AmbientUrlLauncher = staticAmbientOf<UrlLauncher> { error("Needs to be provided") }

app/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml

@@ -1,5 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android">
-  <background android:drawable="@mipmap/ic_launcher_background" />
-  <foreground android:drawable="@mipmap/ic_launcher_foreground" />
-</adaptive-icon>