From 9fe6e34015101b61d973a96b6ba6cb4ee6b6cfb2 Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Tue, 7 May 2024 13:09:30 +0530 Subject: [PATCH] chore: make `LaunchedEffect` keys consistent --- .../msfjarvis/claw/android/ui/screens/LobstersPostsScreen.kt | 2 +- .../main/kotlin/dev/msfjarvis/claw/common/ui/NetworkError.kt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/screens/LobstersPostsScreen.kt b/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/screens/LobstersPostsScreen.kt index 7806e82c..54d3bfef 100644 --- a/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/screens/LobstersPostsScreen.kt +++ b/android/src/main/kotlin/dev/msfjarvis/claw/android/ui/screens/LobstersPostsScreen.kt @@ -119,7 +119,7 @@ fun LobstersPostsScreen( val navigationType = ClawNavigationType.fromSize(windowSizeClass.widthSizeClass) val postIdOverride = context.getActivity()?.intent?.extras?.getString(MainActivity.NAVIGATION_KEY) - LaunchedEffect(false) { + LaunchedEffect(Unit) { if (postIdOverride != null) { navController.navigate(Comments(postIdOverride)) } diff --git a/common/src/main/kotlin/dev/msfjarvis/claw/common/ui/NetworkError.kt b/common/src/main/kotlin/dev/msfjarvis/claw/common/ui/NetworkError.kt index c445e282..85c748e0 100644 --- a/common/src/main/kotlin/dev/msfjarvis/claw/common/ui/NetworkError.kt +++ b/common/src/main/kotlin/dev/msfjarvis/claw/common/ui/NetworkError.kt @@ -30,7 +30,7 @@ import io.github.aakira.napier.Napier @Composable fun NetworkError(label: String, error: Throwable, modifier: Modifier = Modifier) { - LaunchedEffect(true) { Napier.e(error, "NetworkError") { "Failed to load posts" } } + LaunchedEffect(Unit) { Napier.e(error, "NetworkError") { "Failed to load posts" } } var showDialog by remember { mutableStateOf(false) } Column(verticalArrangement = Arrangement.spacedBy(4.dp), modifier = modifier) { Text(