From a19aa169242586679a2901e16ee983afaf619090 Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Sat, 10 Sep 2022 16:42:14 +0530 Subject: [PATCH] fix(metadata-extractor): do not attempt extraction on HTTP URLs These can pop up on lobste.rs rarely but Android only allows us to do HTTPS, so the ideal solution is to just skip them and render as-is. --- .../main/kotlin/dev/msfjarvis/claw/metadata/MetadataExtractor.kt | 1 + 1 file changed, 1 insertion(+) diff --git a/metadata-extractor/src/main/kotlin/dev/msfjarvis/claw/metadata/MetadataExtractor.kt b/metadata-extractor/src/main/kotlin/dev/msfjarvis/claw/metadata/MetadataExtractor.kt index 7b711ff1..ceeb0346 100644 --- a/metadata-extractor/src/main/kotlin/dev/msfjarvis/claw/metadata/MetadataExtractor.kt +++ b/metadata-extractor/src/main/kotlin/dev/msfjarvis/claw/metadata/MetadataExtractor.kt @@ -19,6 +19,7 @@ constructor( suspend fun getExtractedMetadata(url: String): LinkMetadata { val parsedUrl = url.toHttpUrlOrNull() ?: return makeDefault(url) + if (!parsedUrl.isHttps) return makeDefault(url) val request = Request.Builder().url(parsedUrl).build() val htmlContent = okHttpClient.newCall(request).execute().use { response ->