From a1ab32c43eb7be2e0e3d77f53c6c5f6a09f5325b Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Mon, 3 Oct 2022 22:39:44 +0530 Subject: [PATCH] refactor(common): fix Modifier re-use --- .../kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt | 4 ++-- detekt-baselines/common.xml | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/common/src/main/kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt b/common/src/main/kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt index eb91629c..487dd396 100644 --- a/common/src/main/kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt +++ b/common/src/main/kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt @@ -145,10 +145,10 @@ fun Submitter( url = avatarUrl, placeholder = ClawIcons.Account, contentDescription = contentDescription, - modifier = modifier.requiredSize(24.dp).clip(CircleShape), + modifier = Modifier.requiredSize(24.dp).clip(CircleShape), ) - Text(text = text, modifier = modifier, style = MaterialTheme.typography.bodyMedium) + Text(text = text, style = MaterialTheme.typography.bodyMedium) } } diff --git a/detekt-baselines/common.xml b/detekt-baselines/common.xml index 3bedeb54..28fb4e99 100644 --- a/detekt-baselines/common.xml +++ b/detekt-baselines/common.xml @@ -5,8 +5,6 @@ MagicNumber:CommentEntry.kt$16 MagicNumber:Theme.kt$31 ModifierMissing:ClawAppBar.kt$ClawAppBarPreview - ModifierReused:LobstersCard.kt$Row( modifier = modifier, verticalAlignment = Alignment.CenterVertically, horizontalArrangement = Arrangement.spacedBy(8.dp), ) { NetworkImage( url = avatarUrl, placeholder = ClawIcons.Account, contentDescription = contentDescription, modifier = modifier.requiredSize(24.dp).clip(CircleShape), ) Text(text = text, modifier = modifier, style = MaterialTheme.typography.bodyMedium) } - ModifierReused:LobstersCard.kt$Text(text = text, modifier = modifier, style = MaterialTheme.typography.bodyMedium) SpreadOperator:Theme.kt$(*providedValues)