From ab905d4061b97f254d81a4966a758c3c38642b92 Mon Sep 17 00:00:00 2001
From: Harsh Shandilya <me@msfjarvis.dev>
Date: Fri, 3 Mar 2023 15:45:00 +0530
Subject: [PATCH] fix(build): set a default for `sentryDsn`

---
 .../main/kotlin/dev/msfjarvis/claw/gradle/SentryPlugin.kt | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/build-logic/src/main/kotlin/dev/msfjarvis/claw/gradle/SentryPlugin.kt b/build-logic/src/main/kotlin/dev/msfjarvis/claw/gradle/SentryPlugin.kt
index af8f342d..ede6e80d 100644
--- a/build-logic/src/main/kotlin/dev/msfjarvis/claw/gradle/SentryPlugin.kt
+++ b/build-logic/src/main/kotlin/dev/msfjarvis/claw/gradle/SentryPlugin.kt
@@ -25,11 +25,9 @@ class SentryPlugin : Plugin<Project> {
       val catalog = project.extensions.getByType<VersionCatalogsExtension>()
       val libs = catalog.named("libs")
       project.extensions.configure<ApplicationAndroidComponentsExtension> {
-        onVariants(selector()) { variant ->
+        onVariants(selector().all()) { variant ->
           val sentryDsn = project.providers.environmentVariable(SENTRY_DSN_PROPERTY)
-          if (sentryDsn.isPresent) {
-            variant.manifestPlaceholders.put("sentryDsn", sentryDsn.get())
-          }
+          variant.manifestPlaceholders.put("sentryDsn", sentryDsn.getOrElse(""))
         }
       }
       project.plugins.apply(io.sentry.android.gradle.SentryPlugin::class)
@@ -42,7 +40,7 @@ class SentryPlugin : Plugin<Project> {
         autoUploadNativeSymbols.set(false)
         includeNativeSources.set(false)
         ignoredVariants.set(emptySet())
-        ignoredBuildTypes.set(setOf("debug"))
+        ignoredBuildTypes.set(setOf("benchmark", "debug"))
         ignoredFlavors.set(emptySet())
         tracingInstrumentation {
           enabled.set(true)