From b30ab6a5376ac44186fc0bec5ef6aac89839513b Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Fri, 25 Sep 2020 14:35:10 +0530 Subject: [PATCH] Revert "app: use ConstraintLayout for laying out LobstersItem" Won't solve the problem I was hoping to solve. This reverts commit a14484583da05263fff85c71be393f652e5fb5d8. --- .../dev/msfjarvis/lobsters/ui/LobstersItem.kt | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/app/src/main/java/dev/msfjarvis/lobsters/ui/LobstersItem.kt b/app/src/main/java/dev/msfjarvis/lobsters/ui/LobstersItem.kt index f337b6d5..d57ec967 100644 --- a/app/src/main/java/dev/msfjarvis/lobsters/ui/LobstersItem.kt +++ b/app/src/main/java/dev/msfjarvis/lobsters/ui/LobstersItem.kt @@ -6,7 +6,7 @@ import androidx.compose.foundation.background import androidx.compose.foundation.border import androidx.compose.foundation.clickable import androidx.compose.foundation.layout.Arrangement -import androidx.compose.foundation.layout.ConstraintLayout +import androidx.compose.foundation.layout.Column import androidx.compose.foundation.layout.Row import androidx.compose.foundation.layout.padding import androidx.compose.foundation.lazy.LazyColumnFor @@ -33,21 +33,15 @@ fun LazyItemScope.LobstersItem( .fillParentMaxWidth() .clickable(onClick = { onClick.invoke(post) }), text = { - ConstraintLayout { - val (title, tags, submitter) = createRefs() + Column { Text( text = post.title, color = Color(0xFF7395D9), fontWeight = FontWeight.Bold, - modifier = Modifier.padding(top = 4.dp).constrainAs(title) { - top.linkTo(parent.top) - start.linkTo(parent.start) - } + modifier = Modifier.padding(top = 4.dp) ) Row( - modifier = Modifier.padding(vertical = 8.dp).constrainAs(tags) { - top.linkTo(title.bottom) - }, + modifier = Modifier.padding(vertical = 8.dp), horizontalArrangement = Arrangement.spacedBy(8.dp), ) { post.tags.forEach { tag -> @@ -63,9 +57,7 @@ fun LazyItemScope.LobstersItem( } Text( text = "submitted by ${post.submitterUser.username}", - modifier = Modifier.padding(bottom = 4.dp).constrainAs(submitter) { - top.linkTo(tags.bottom) - }, + modifier = Modifier.padding(bottom = 4.dp), ) } }