From b498cf4b626ad294d7c224e5b2a446a21ddb42d5 Mon Sep 17 00:00:00 2001
From: Harsh Shandilya <me@msfjarvis.dev>
Date: Thu, 4 May 2023 14:09:05 +0530
Subject: [PATCH] feat: fix Sentry disabling logic again

---
 android/src/benchmark/AndroidManifest.xml         |  7 -------
 android/src/main/AndroidManifest.xml              |  9 +++++++++
 android/src/release/AndroidManifest.xml           | 15 ---------------
 .../dev/msfjarvis/claw/gradle/SentryPlugin.kt     |  9 +++++++++
 4 files changed, 18 insertions(+), 22 deletions(-)
 delete mode 100644 android/src/benchmark/AndroidManifest.xml
 delete mode 100644 android/src/release/AndroidManifest.xml

diff --git a/android/src/benchmark/AndroidManifest.xml b/android/src/benchmark/AndroidManifest.xml
deleted file mode 100644
index 2ae27210..00000000
--- a/android/src/benchmark/AndroidManifest.xml
+++ /dev/null
@@ -1,7 +0,0 @@
-<?xml version="1.0" encoding="utf-8" ?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android">
-  <application>
-    <!-- Required: set your sentry.io project identifier (DSN) -->
-    <meta-data android:name="io.sentry.dsn" android:value="${sentryDsn}" />
-  </application>
-</manifest>
diff --git a/android/src/main/AndroidManifest.xml b/android/src/main/AndroidManifest.xml
index 962d7944..ababa53a 100644
--- a/android/src/main/AndroidManifest.xml
+++ b/android/src/main/AndroidManifest.xml
@@ -163,5 +163,14 @@
         <action android:name="androidx.profileinstaller.action.BENCHMARK_OPERATION" />
       </intent-filter>
     </receiver>
+    <!-- Required: set your sentry.io project identifier (DSN) -->
+    <meta-data android:name="io.sentry.dsn" android:value="${sentryDsn}" />
+    <!-- enable automatic breadcrumbs for user interactions (clicks, swipes, scrolls) -->
+    <meta-data android:name="io.sentry.traces.user-interaction.enable" android:value="${enableSentry}" />
+    <meta-data android:name="io.sentry.breadcrumbs.user-interaction" android:value="${enableSentry}" />
+    <!-- enable screenshot for crashes -->
+    <meta-data android:name="io.sentry.attach-screenshot" android:value="${enableSentry}" />
+    <!-- enable view hierarchy for crashes -->
+    <meta-data android:name="io.sentry.attach-view-hierarchy" android:value="${enableSentry}" />
   </application>
 </manifest>
diff --git a/android/src/release/AndroidManifest.xml b/android/src/release/AndroidManifest.xml
deleted file mode 100644
index e9c46fa8..00000000
--- a/android/src/release/AndroidManifest.xml
+++ /dev/null
@@ -1,15 +0,0 @@
-<?xml version="1.0" encoding="utf-8" ?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android">
-  <application>
-    <!-- Required: set your sentry.io project identifier (DSN) -->
-    <meta-data android:name="io.sentry.dsn" android:value="${sentryDsn}" />
-
-    <!-- enable automatic breadcrumbs for user interactions (clicks, swipes, scrolls) -->
-    <meta-data android:name="io.sentry.traces.user-interaction.enable" android:value="true" />
-    <meta-data android:name="io.sentry.breadcrumbs.user-interaction" android:value="true" />
-    <!-- enable screenshot for crashes -->
-    <meta-data android:name="io.sentry.attach-screenshot" android:value="true" />
-    <!-- enable view hierarchy for crashes -->
-    <meta-data android:name="io.sentry.attach-view-hierarchy" android:value="true" />
-  </application>
-</manifest>
diff --git a/build-logic/src/main/kotlin/dev/msfjarvis/claw/gradle/SentryPlugin.kt b/build-logic/src/main/kotlin/dev/msfjarvis/claw/gradle/SentryPlugin.kt
index ede6e80d..b60028f8 100644
--- a/build-logic/src/main/kotlin/dev/msfjarvis/claw/gradle/SentryPlugin.kt
+++ b/build-logic/src/main/kotlin/dev/msfjarvis/claw/gradle/SentryPlugin.kt
@@ -29,6 +29,15 @@ class SentryPlugin : Plugin<Project> {
           val sentryDsn = project.providers.environmentVariable(SENTRY_DSN_PROPERTY)
           variant.manifestPlaceholders.put("sentryDsn", sentryDsn.getOrElse(""))
         }
+        onVariants(selector().withBuildType("benchmark")) { variant ->
+          variant.manifestPlaceholders.put("enableSentry", "false")
+        }
+        onVariants(selector().withBuildType("debug")) { variant ->
+          variant.manifestPlaceholders.put("enableSentry", "false")
+        }
+        onVariants(selector().withBuildType("release")) { variant ->
+          variant.manifestPlaceholders.put("enableSentry", "true")
+        }
       }
       project.plugins.apply(io.sentry.android.gradle.SentryPlugin::class)
       project.extensions.configure<SentryPluginExtension> {