From bad5bf5457224bcd299198c24d1e207d573ef302 Mon Sep 17 00:00:00 2001
From: Harsh Shandilya <me@msfjarvis.dev>
Date: Tue, 18 Jul 2023 17:11:06 +0530
Subject: [PATCH] refactor(api): make SearchConverter a singleton

---
 .../dev/msfjarvis/claw/api/converters/SearchConverter.kt   | 7 +++----
 .../test/kotlin/dev/msfjarvis/claw/api/SearchApiWrapper.kt | 7 +++----
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/api/src/main/kotlin/dev/msfjarvis/claw/api/converters/SearchConverter.kt b/api/src/main/kotlin/dev/msfjarvis/claw/api/converters/SearchConverter.kt
index 1faf42a9..ef6e2560 100644
--- a/api/src/main/kotlin/dev/msfjarvis/claw/api/converters/SearchConverter.kt
+++ b/api/src/main/kotlin/dev/msfjarvis/claw/api/converters/SearchConverter.kt
@@ -10,7 +10,6 @@ import dev.msfjarvis.claw.api.LobstersApi
 import dev.msfjarvis.claw.model.LobstersPost
 import dev.msfjarvis.claw.model.User
 import java.lang.reflect.Type
-import javax.inject.Inject
 import okhttp3.ResponseBody
 import org.jsoup.Jsoup
 import org.jsoup.nodes.Element
@@ -18,7 +17,7 @@ import org.jsoup.select.Elements
 import retrofit2.Converter
 import retrofit2.Retrofit
 
-class SearchConverter @Inject constructor() : Converter<ResponseBody, List<LobstersPost>> {
+object SearchConverter : Converter<ResponseBody, List<LobstersPost>> {
   override fun convert(value: ResponseBody): List<LobstersPost> {
     val elements =
       Jsoup.parse(value.string(), LobstersApi.BASE_URL).select("div.story_liner.h-entry")
@@ -74,13 +73,13 @@ class SearchConverter @Inject constructor() : Converter<ResponseBody, List<Lobst
     )
   }
 
-  class Factory @Inject constructor(private val converter: SearchConverter) : Converter.Factory() {
+  object Factory : Converter.Factory() {
     override fun responseBodyConverter(
       type: Type,
       annotations: Array<out Annotation>,
       retrofit: Retrofit
     ): Converter<ResponseBody, List<LobstersPost>> {
-      return converter
+      return SearchConverter
     }
   }
 }
diff --git a/api/src/test/kotlin/dev/msfjarvis/claw/api/SearchApiWrapper.kt b/api/src/test/kotlin/dev/msfjarvis/claw/api/SearchApiWrapper.kt
index 1d544784..30c7ba84 100644
--- a/api/src/test/kotlin/dev/msfjarvis/claw/api/SearchApiWrapper.kt
+++ b/api/src/test/kotlin/dev/msfjarvis/claw/api/SearchApiWrapper.kt
@@ -20,10 +20,9 @@ class SearchApiWrapper(controller: EitherNetController<LobstersSearchApi>) {
   init {
     controller.enqueue(LobstersSearchApi::searchPosts) {
       success(
-        SearchConverter()
-          .convert(
-            ResponseBody.create(MediaType.get("text/html"), getResource("search_chatgpt_page.html"))
-          )
+        SearchConverter.convert(
+          ResponseBody.create(MediaType.get("text/html"), getResource("search_chatgpt_page.html"))
+        )
       )
     }
   }