msfjarvis/compose-lobsters
1
Fork 0
mirror of https://github.com/msfjarvis/compose-lobsters synced 2025-08-14 22:17:03 +05:30
Code Issues Projects Releases Packages Wiki Activity Actions 4

Revert "Revert "Revert "fix(common): make text in comments screen selectable"""

Browse source 
Still causes crashes :(

This reverts commit c5ec6cd680.

Fixes COMPOSE-LOBSTERS-16
This commit is contained in:
Harsh Shandilya 2023-07-27 01:28:21 +05:30
parent 72b9409383
commit bcf4f02a01
No known key found for this signature in database
1 changed files with 6 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

7
common/src/main/kotlin/dev/msfjarvis/claw/common/comments/CommentEntry.kt
View file

@ -19,7 +19,6 @@ import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.foundation.text.selection.SelectionContainer
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.filled.Public
import androidx.compose.material3.MaterialTheme
@ -71,7 +70,7 @@ internal fun CommentsHeader(
modifier = Modifier.padding(16.dp).fillMaxWidth(),
verticalArrangement = Arrangement.spacedBy(8.dp),
) {
SelectionContainer { PostTitle(title = postDetails.title) }
PostTitle(title = postDetails.title)
TagRow(tags = postDetails.tags.toImmutableList())
Spacer(Modifier.height(4.dp))
@ -85,9 +84,7 @@ internal fun CommentsHeader(
}
if (postDetails.description.isNotBlank()) {
SelectionContainer {
ThemedRichText(htmlConverter.convertHTMLToMarkdown(postDetails.description))
}
Spacer(Modifier.height(4.dp))
}
Submitter(
@ -172,7 +169,6 @@ internal fun CommentEntry(
Modifier.clickable { uriHandler.openUri("https://lobste.rs/u/${comment.user.username}") },
)
if (commentNode.isExpanded) {
SelectionContainer {
ThemedRichText(
text = htmlConverter.convertHTMLToMarkdown(comment.comment),
modifier = Modifier.padding(top = 8.dp)
@ -181,7 +177,6 @@ internal fun CommentEntry(
}
}
}
}
@Composable
fun buildCommenterString(