From c8eaf8d769e7ae46594c91a5106847f1bb01bd04 Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Wed, 24 Apr 2024 22:56:55 +0530 Subject: [PATCH] fix(api): remove sentry-okhttp integration This keeps logging HTTP 500 errors despite me opting out of them Fixes COMPOSE-LOBSTERS-2T --- core/build.gradle.kts | 3 +-- .../dev/msfjarvis/claw/core/injection/OkHttpModule.kt | 9 --------- gradle/libs.versions.toml | 1 - 3 files changed, 1 insertion(+), 12 deletions(-) diff --git a/core/build.gradle.kts b/core/build.gradle.kts index ccd37a1b..d1477b84 100644 --- a/core/build.gradle.kts +++ b/core/build.gradle.kts @@ -1,5 +1,5 @@ /* - * Copyright © 2022-2023 Harsh Shandilya. + * Copyright © 2022-2024 Harsh Shandilya. * Use of this source code is governed by an MIT-style * license that can be found in the LICENSE file or at * https://opensource.org/licenses/MIT. @@ -27,5 +27,4 @@ dependencies { implementation(libs.napier) implementation(libs.okhttp.core) implementation(libs.retrofit.kotlinxSerializationConverter) - implementation(libs.sentry.okhttp) } diff --git a/core/src/main/kotlin/dev/msfjarvis/claw/core/injection/OkHttpModule.kt b/core/src/main/kotlin/dev/msfjarvis/claw/core/injection/OkHttpModule.kt index a68c337a..3cf300a3 100644 --- a/core/src/main/kotlin/dev/msfjarvis/claw/core/injection/OkHttpModule.kt +++ b/core/src/main/kotlin/dev/msfjarvis/claw/core/injection/OkHttpModule.kt @@ -18,7 +18,6 @@ import dagger.multibindings.IntoSet import dev.msfjarvis.claw.core.network.DelegatingSocketFactory import dev.msfjarvis.claw.core.network.NapierLogger import dev.msfjarvis.claw.core.network.UserAgentInterceptor -import io.sentry.okhttp.SentryOkHttpInterceptor import java.net.Socket import javax.net.SocketFactory import okhttp3.Cache @@ -88,13 +87,5 @@ interface OkHttpModule { fun provideHttpLoggingInterceptor(logger: HttpLoggingInterceptor.Logger): Interceptor { return HttpLoggingInterceptor(logger).setLevel(HttpLoggingInterceptor.Level.BASIC) } - - @Provides - @IntoSet - fun provideSentryInterceptor(): Interceptor { - // Disable capturing of failed requests since there is no real upstream for this app, - // if something is going wrong it is almost always someone else's problem. - return SentryOkHttpInterceptor(captureFailedRequests = false) - } } } diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index 7df40379..050c91ad 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -95,7 +95,6 @@ retrofit = { module = "com.squareup.retrofit2:retrofit", version.ref = "retrofit retrofit-kotlinxSerializationConverter = { module = "com.squareup.retrofit2:converter-kotlinx-serialization", version.ref = "retrofit" } sentry-android = { module = "io.sentry:sentry-android", version.ref = "sentry-sdk" } sentry-bom = { module = "io.sentry:sentry-bom", version.ref = "sentry-sdk" } -sentry-okhttp = { module = "io.sentry:sentry-okhttp", version.ref = "sentry-sdk" } slack-compose-lints = "com.slack.lint.compose:compose-lint-checks:1.3.1" slack-lints = "com.slack.lint:slack-lint-checks:0.7.1" sqldelight-androidDriver = { module = "app.cash.sqldelight:android-driver", version.ref = "sqldelight" }