msfjarvis/compose-lobsters
1
Fork 0
mirror of https://github.com/msfjarvis/compose-lobsters synced 2025-08-14 22:17:03 +05:30
Code Issues Projects Releases Packages Wiki Activity Actions 4

chore(common): tweak LobstersCard UI

Browse source 
Cut down on paddings and use colors more explicitly
This commit is contained in:
Harsh Shandilya 2023-08-15 15:55:05 +05:30
parent 67e621160f
commit cbf0707aa6
No known key found for this signature in database
1 changed files with 11 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

19
common/src/main/kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt
View file

@ -16,7 +16,6 @@ import androidx.compose.foundation.layout.ExperimentalLayoutApi
import androidx.compose.foundation.layout.FlowRow import androidx.compose.foundation.layout.FlowRow
import androidx.compose.foundation.layout.Row import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.absoluteOffset
import androidx.compose.foundation.layout.fillMaxWidth import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding import androidx.compose.foundation.layout.padding
@ -72,6 +71,7 @@ fun LobstersCard(
modifier modifier
.fillMaxWidth() .fillMaxWidth()
.clickable { postActions.viewPost(post.url, post.commentsUrl) } .clickable { postActions.viewPost(post.url, post.commentsUrl) }
.background(MaterialTheme.colorScheme.background)
.padding(start = 16.dp, top = 16.dp, end = 4.dp, bottom = 16.dp), .padding(start = 16.dp, top = 16.dp, end = 4.dp, bottom = 16.dp),
) { ) {
Row( Row(
@ -132,7 +132,8 @@ internal fun PostTitle(
text = title, text = title,
modifier = modifier, modifier = modifier,
style = MaterialTheme.typography.titleMedium, style = MaterialTheme.typography.titleMedium,
fontWeight = FontWeight.Bold fontWeight = FontWeight.Bold,
color = MaterialTheme.colorScheme.onBackground,
) )
} }
@ -153,9 +154,14 @@ internal fun Submitter(
placeholder = Icons.Filled.AccountCircle, placeholder = Icons.Filled.AccountCircle,
contentDescription = contentDescription, contentDescription = contentDescription,
modifier = Modifier.requiredSize(24.dp).clip(CircleShape), modifier = Modifier.requiredSize(24.dp).clip(CircleShape),
placeholderTintColor = MaterialTheme.colorScheme.onBackground,
) )
Text(text = text, style = MaterialTheme.typography.bodyMedium) Text(
text = text,
style = MaterialTheme.typography.bodyMedium,
color = MaterialTheme.colorScheme.onBackground,
)
} }
} }
@ -187,7 +193,6 @@ private fun CommentsButton(
badge = { badge = {
if (commentCount != null) { if (commentCount != null) {
Badge( Badge(
modifier = Modifier.absoluteOffset(x = -(8.dp)),
containerColor = MaterialTheme.colorScheme.tertiaryContainer, containerColor = MaterialTheme.colorScheme.tertiaryContainer,
) { ) {
Text( Text(
@ -203,7 +208,7 @@ private fun CommentsButton(
imageVector = Icons.Filled.Comment, imageVector = Icons.Filled.Comment,
tint = MaterialTheme.colorScheme.secondary, tint = MaterialTheme.colorScheme.secondary,
contentDescription = "Open comments", contentDescription = "Open comments",
modifier = Modifier.align(Alignment.Center).testTag("comments_button"), modifier = Modifier.testTag("comments_button"),
) )
} }
} }
@ -218,9 +223,7 @@ internal fun TagRow(
modifier = modifier, modifier = modifier,
horizontalArrangement = Arrangement.spacedBy(8.dp), horizontalArrangement = Arrangement.spacedBy(8.dp),
) { ) {
tags.forEach { tag -> tags.forEach { tag -> TagText(tag = tag) }
TagText(tag = tag, modifier = Modifier.padding(top = 4.dp, bottom = 4.dp))
}
} }
} }