From d178bebebd6a891bfb6d800a5922eb82090160e7 Mon Sep 17 00:00:00 2001
From: Harsh Shandilya <me@msfjarvis.dev>
Date: Mon, 3 Oct 2022 11:58:41 +0530
Subject: [PATCH] refactor(common): ensure exceptions in `UrlLauncher` are
 logged

---
 .../kotlin/dev/msfjarvis/claw/common/urllauncher/UrlLauncher.kt | 2 +-
 detekt-baselines/common.xml                                     | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/common/src/main/kotlin/dev/msfjarvis/claw/common/urllauncher/UrlLauncher.kt b/common/src/main/kotlin/dev/msfjarvis/claw/common/urllauncher/UrlLauncher.kt
index 997a0397..0e1295a8 100644
--- a/common/src/main/kotlin/dev/msfjarvis/claw/common/urllauncher/UrlLauncher.kt
+++ b/common/src/main/kotlin/dev/msfjarvis/claw/common/urllauncher/UrlLauncher.kt
@@ -20,7 +20,7 @@ class UrlLauncher(private val context: Context) : UriHandler {
       customTabsIntent.launchUrl(context, Uri.parse(uri))
     } catch (e: ActivityNotFoundException) {
       val error = "Failed to open URL: $uri"
-      Napier.d(tag = "UrlLauncher") { error }
+      Napier.d(throwable = e, tag = "UrlLauncher") { error }
       Toast.makeText(context, error, Toast.LENGTH_SHORT).show()
     }
   }
diff --git a/detekt-baselines/common.xml b/detekt-baselines/common.xml
index c3159ed4..7a3d81f7 100644
--- a/detekt-baselines/common.xml
+++ b/detekt-baselines/common.xml
@@ -12,7 +12,6 @@
     <ID>ModifierReused:LobstersCard.kt$Row( modifier = modifier, verticalAlignment = Alignment.CenterVertically, horizontalArrangement = Arrangement.spacedBy(8.dp), ) { NetworkImage( url = avatarUrl, placeholder = ClawIcons.Account, contentDescription = contentDescription, modifier = modifier.requiredSize(24.dp).clip(CircleShape), ) Text(text = text, modifier = modifier, style = MaterialTheme.typography.bodyMedium) }</ID>
     <ID>ModifierReused:LobstersCard.kt$Text(text = text, modifier = modifier, style = MaterialTheme.typography.bodyMedium)</ID>
     <ID>SpreadOperator:Theme.kt$(*providedValues)</ID>
-    <ID>SwallowedException:UrlLauncher.kt$UrlLauncher$e: ActivityNotFoundException</ID>
     <ID>ThrowingExceptionsWithoutMessageOrCause:NetworkError.kt$Throwable()</ID>
     <ID>UnnecessaryAbstractClass:BasePaparazziTest.kt$BasePaparazziTest$BasePaparazziTest</ID>
   </CurrentIssues>