From 879cb951a0a7c5ed1a63c701bb3e0e9ea04094c9 Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Mon, 15 Mar 2021 21:57:19 +0530 Subject: [PATCH 1/2] app: don't attempt to scroll if posts are loading Signed-off-by: Harsh Shandilya --- .../main/java/dev/msfjarvis/lobsters/ui/main/LobstersApp.kt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/dev/msfjarvis/lobsters/ui/main/LobstersApp.kt b/app/src/main/java/dev/msfjarvis/lobsters/ui/main/LobstersApp.kt index bbcea9f7..65abc778 100644 --- a/app/src/main/java/dev/msfjarvis/lobsters/ui/main/LobstersApp.kt +++ b/app/src/main/java/dev/msfjarvis/lobsters/ui/main/LobstersApp.kt @@ -20,6 +20,7 @@ import androidx.navigation.compose.composable import androidx.navigation.compose.currentBackStackEntryAsState import androidx.navigation.compose.navigate import androidx.navigation.compose.rememberNavController +import androidx.paging.LoadState import androidx.paging.compose.collectAsLazyPagingItems import dev.msfjarvis.lobsters.ui.navigation.Destination import dev.msfjarvis.lobsters.ui.posts.HottestPosts @@ -47,7 +48,9 @@ fun LobstersApp() { } } val jumpToIndex: suspend (Int) -> Unit = { - hottestPostsListState.animateScrollToItem(it) + if (hottestPosts.loadState.refresh != LoadState.Loading) { + hottestPostsListState.animateScrollToItem(it) + } } Scaffold( From 8bf42fa46ae2202b49f52408d5cf441703ddae46 Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Mon, 15 Mar 2021 21:57:40 +0530 Subject: [PATCH 2/2] Disable KMP warning Signed-off-by: Harsh Shandilya --- .idea/artifacts/common_jvm.xml | 4 +++- gradle.properties | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.idea/artifacts/common_jvm.xml b/.idea/artifacts/common_jvm.xml index eeeaa0fe..256528c5 100644 --- a/.idea/artifacts/common_jvm.xml +++ b/.idea/artifacts/common_jvm.xml @@ -1,6 +1,8 @@ $PROJECT_DIR$/common/build/libs - + + + \ No newline at end of file diff --git a/gradle.properties b/gradle.properties index 81d10321..05ae5ade 100644 --- a/gradle.properties +++ b/gradle.properties @@ -48,3 +48,6 @@ android.defaults.buildfeatures.renderscript=false android.defaults.buildfeatures.resvalues=false android.defaults.buildfeatures.shaders=false android.library.defaults.buildfeatures.androidresources=false + +# Disable KMP warning +kotlin.mpp.stability.nowarn=true