refactor: address issues from compose-lint 1.3.x

android/src/main/kotlin/dev/msfjarvis/claw/android/BaseActivity.kt

@@ -15,6 +15,7 @@ import androidx.activity.SystemBarStyle
 import androidx.activity.compose.setContent
 import androidx.activity.enableEdgeToEdge
 import androidx.compose.runtime.Composable
+import androidx.compose.runtime.Stable
 import androidx.compose.ui.platform.LocalUriHandler
 import com.deliveryhero.whetstone.Whetstone
 import dev.msfjarvis.claw.android.viewmodel.ClawViewModel
@@ -24,6 +25,7 @@ import dev.msfjarvis.claw.common.urllauncher.UrlLauncher
 import javax.inject.Inject
 
 /** A base class that encapsulates all activities used by Claw. */
+@Stable
 abstract class BaseActivity : ComponentActivity() {
 
   @Inject lateinit var urlLauncher: UrlLauncher

android/src/main/kotlin/dev/msfjarvis/claw/android/glance/SavedPostsWidget.kt

@@ -29,6 +29,8 @@ import androidx.glance.text.TextStyle
 import dev.msfjarvis.claw.common.theme.DarkThemeColors
 import dev.msfjarvis.claw.common.theme.LightThemeColors
 import dev.msfjarvis.claw.database.local.SavedPost
+import kotlinx.collections.immutable.ImmutableList
+import kotlinx.collections.immutable.toImmutableList
 
 class SavedPostsWidget(private val posts: List<SavedPost>) : GlanceAppWidget() {
   override suspend fun provideGlance(context: Context, id: GlanceId) {
@@ -37,35 +39,33 @@ class SavedPostsWidget(private val posts: List<SavedPost>) : GlanceAppWidget() {
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) GlanceTheme.colors
         else ColorProviders(light = LightThemeColors, dark = DarkThemeColors)
       ) {
-        WidgetHost()
+        WidgetHost(posts.toImmutableList())
       }
     }
   }
+}
 
-  @Composable
+@Composable
-  private fun WidgetHost() {
+fun WidgetHost(posts: ImmutableList<SavedPost>, modifier: GlanceModifier = GlanceModifier) {
-    LazyColumn(
+  LazyColumn(
-      modifier =
+    modifier =
-        GlanceModifier.fillMaxSize()
+      modifier.fillMaxSize().background(GlanceTheme.colors.background).appWidgetBackground(),
-          .background(GlanceTheme.colors.background)
+    horizontalAlignment = Alignment.CenterHorizontally,
-          .appWidgetBackground(),
+  ) {
-      horizontalAlignment = Alignment.CenterHorizontally,
+    item {
-    ) {
+      val style = MaterialTheme.typography.titleLarge
-      item {
+      Text(
-        val style = MaterialTheme.typography.titleLarge
+        text = "Saved posts",
-        Text(
+        style =
-          text = "Saved posts",
+          TextStyle(
-          style =
+            color = GlanceTheme.colors.onBackground,
-            TextStyle(
+            fontSize = style.fontSize,
-              color = GlanceTheme.colors.onBackground,
+            fontWeight = style.fontWeight.toGlance(),
-              fontSize = style.fontSize,
+            fontStyle = style.fontStyle.toGlance(),
-              fontWeight = style.fontWeight.toGlance(),
+          ),
-              fontStyle = style.fontStyle.toGlance(),
+        modifier = GlanceModifier.padding(vertical = 8.dp),
-            ),
+      )
-          modifier = GlanceModifier.padding(vertical = 8.dp),
-        )
-      }
-      items(posts) { post -> WidgetListEntry(post = post) }
     }
+    items(posts) { post -> WidgetListEntry(post = post) }
   }
 }

android/src/main/kotlin/dev/msfjarvis/claw/android/ui/screens/LobstersPostsScreen.kt

@@ -65,7 +65,6 @@ import com.mikepenz.aboutlibraries.ui.compose.m3.LibrariesContainer
 import dev.msfjarvis.claw.android.MainActivity
 import dev.msfjarvis.claw.android.R
 import dev.msfjarvis.claw.android.SearchActivity
-import dev.msfjarvis.claw.android.ui.decorations.ClawAppBar
 import dev.msfjarvis.claw.android.ui.decorations.ClawNavigationBar
 import dev.msfjarvis.claw.android.ui.decorations.ClawNavigationRail
 import dev.msfjarvis.claw.android.ui.decorations.NavigationItem
@@ -79,6 +78,7 @@ import dev.msfjarvis.claw.android.viewmodel.ClawViewModel
 import dev.msfjarvis.claw.api.LobstersApi
 import dev.msfjarvis.claw.common.comments.CommentsPage
 import dev.msfjarvis.claw.common.comments.HTMLConverter
+import dev.msfjarvis.claw.common.ui.decorations.ClawAppBar
 import dev.msfjarvis.claw.common.urllauncher.UrlLauncher
 import dev.msfjarvis.claw.common.user.UserProfile
 import kotlinx.collections.immutable.persistentListOf

build-logic/src/main/kotlin/dev/msfjarvis/claw/gradle/LintConfig.kt

@@ -1,5 +1,5 @@
 /*
- * Copyright © 2023 Harsh Shandilya.
+ * Copyright © 2023-2024 Harsh Shandilya.
  * Use of this source code is governed by an MIT-style
  * license that can be found in the LICENSE file or at
  * https://opensource.org/licenses/MIT.
@@ -39,8 +39,6 @@ object LintConfig {
     disable += "AndroidGradlePluginVersion"
     disable += "GradleDependency"
     disable += "NewerVersionAvailable"
-    // Jetpack Compose lints are incompatible with AGP 8.3.0-alpha06
-    disable += "ObsoleteLintCustomCheck"
   }
 
   fun configureRootProject(project: Project) {

common/src/main/kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt

@@ -230,7 +230,7 @@ private fun TagText(tag: String, modifier: Modifier = Modifier) {
 
 @ThemePreviews
 @Composable
-fun LobstersCardPreview() {
+private fun LobstersCardPreview() {
   LobstersTheme {
     LobstersCard(
       post =

common/src/main/kotlin/dev/msfjarvis/claw/common/ui/SearchBar.kt

@@ -70,7 +70,7 @@ fun SearchBar(
 @DevicePreviews
 @ThemePreviews
 @Composable
-fun SearchBarPreview() {
+private fun SearchBarPreview() {
   LobstersTheme {
     Box(Modifier.fillMaxWidth().background(MaterialTheme.colorScheme.background).padding(8.dp)) {
       var value by remember { mutableStateOf("") }

common/src/main/kotlin/dev/msfjarvis/claw/common/ui/decorations/ClawAppBar.kt

@@ -4,7 +4,7 @@
  * license that can be found in the LICENSE file or at
  * https://opensource.org/licenses/MIT.
  */
-package dev.msfjarvis.claw.android.ui.decorations
+package dev.msfjarvis.claw.common.ui.decorations
 
 import androidx.compose.foundation.layout.RowScope
 import androidx.compose.material3.ExperimentalMaterial3Api
@@ -45,6 +45,6 @@ fun ClawAppBar(
 @DevicePreviews
 @ThemePreviews
 @Composable
-fun ClawAppBarPreview() {
+private fun ClawAppBarPreview() {
   LobstersTheme { ClawAppBar(title = { Text("Claw", fontWeight = FontWeight.Bold) }) }
 }

common/src/main/kotlin/dev/msfjarvis/claw/common/ui/decorations/MonthHeader.kt

@@ -40,6 +40,6 @@ fun MonthHeader(label: String, modifier: Modifier = Modifier) {
 @DevicePreviews
 @ThemePreviews
 @Composable
-fun MonthHeaderPreview() {
+private fun MonthHeaderPreview() {
   LobstersTheme { MonthHeader("April 2023") }
 }