Commit graph

251 commits

Author SHA1 Message Date
095cb8d3a1
Remove BottomNavigationLayoutTest
Boss man Jim Sproch recommends we use screenshot testing rather than asserting on nodes
since they can change under us at any time as more optimisations come into play.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-25 19:54:43 +05:30
8b976cee3c
BottomNavigationLayoutTest: remove unneeded assertExists
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-25 09:57:08 +05:30
6e77a5e94b
build: update to Compose 1.0.0-beta01
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-24 23:52:17 +05:30
027e3410d8
all: move all Hilt processing to app module
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-23 17:44:41 +05:30
875e4ea32c
Revert "LobstersApp: replace with a BackgroundScaffold"
This reverts commit be58017cac.
2021-02-20 13:58:05 +05:30
72d51d5c52
Revert "app: remove now uneeded navigation code"
This reverts commit 41c64f4b02.
2021-02-20 13:58:01 +05:30
5c39c481b7
app: add proguard rules for release builds
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-17 00:25:41 +05:30
41c64f4b02
app: remove now uneeded navigation code
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-17 00:11:48 +05:30
be58017cac
LobstersApp: replace with a BackgroundScaffold
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-17 00:10:28 +05:30
d82228483d
main: split out LobstersApp
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-16 23:54:16 +05:30
f30fd72778
app: remove unused methods
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-14 18:23:26 +05:30
Aditya Wasan
25b3ad4f8e
Add test for BottomNavigationLayout
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-02-12 13:24:38 +05:30
97eaf20dbc
build(app): add compose testing dependencies
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-12 11:33:23 +05:30
aff52e7d5f
all: reformat
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-11 16:46:50 +05:30
Aditya Wasan
1a6174b1c8
fix typo 2021-02-11 16:45:51 +05:30
98866ee407
Simplify getDestinationFromRoute
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-11 16:45:50 +05:30
Aditya Wasan
703957e2b7
navigation: do not pass navController to composables
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-02-11 16:45:50 +05:30
885c2a5865
build: upgrade to Compose 1.0.0-alpha12
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-11 16:28:34 +05:30
020976e257
build: update remaining dependencies
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-08 14:14:44 +05:30
cdfa20b9a7
build: upgrade to Compose alpha11
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-08 14:14:43 +05:30
Aditya Wasan
0fcf584b01
src: make LobstersRepository a singleton
Earlier both LobstersViewModel and LobstersPagingSource were getting a different instance of LobstersRepository.
This lead to cache issues where LobstersPagingSource filled the cache but it was not available to the LobstersViewModel.

Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-02-05 15:00:23 +05:30
Aditya Wasan
9ce33bba75
src: add isCacheReady to let users know cache status
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-31 23:02:16 +05:30
Aditya Wasan
1251ae3bc0
src: remove is_saved from LobstersPost and fix tests
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-31 18:49:49 +05:30
Aditya Wasan
9e943c82b9
src: add hilt and update hilt modules
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-31 17:51:21 +05:30
Aditya Wasan
9c4c0b1e56
src: use IconToggleButton and add crossfade animation
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-31 17:23:26 +05:30
Aditya Wasan
a5538ece8e
src: add filename to AndroidSqliteDriver
SQLDelight creates a in-memory DB if the file name is null.

Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-31 16:31:20 +05:30
Aditya Wasan
092599d167
src: add isSaved parameter to LobstersItem
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-31 16:17:08 +05:30
Aditya Wasan
a2c058877a
src: add an in-memory map to cache db posts
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-31 15:44:39 +05:30
49d9ceb73a
app: cleanups
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-31 15:06:18 +05:30
Aditya Wasan
7c8cbc4b3f
src: make dataSource non nullable
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-31 14:58:09 +05:30
Aditya Wasan
ff4a2a751f
src: fix is_saved logic
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-31 14:46:29 +05:30
c835a59cbf
proguard(app): disable ProGuard inlining optimisations
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-30 12:51:16 +05:30
Aditya Wasan
f9fcb089a1
src: remove cache and simplify db logic
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-30 12:51:15 +05:30
Aditya Wasan
3bcdcbdac7
Add LobstersRepo to handle DB operations
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-30 12:51:15 +05:30
Aditya Wasan
ab3f112981
Use boolean for is_saved field
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-30 12:51:14 +05:30
bca96ae215
app: switch to SQLDelight version of LobstersPost
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-30 12:51:13 +05:30
b18de72bdd
all: move model classes to database, rename model to api
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-30 12:50:09 +05:30
f17becff10
app: remove Room
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-30 12:50:07 +05:30
33b238c646
LobstersItem: extract hard-coded submitter text
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-28 13:45:13 +05:30
a7bd050013
LobstersItem: use existing BASE_URL field
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-28 13:42:54 +05:30
5ab5d1ece7
LobstersItem: fix submitter name alignment with avatar
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-28 13:41:49 +05:30
07930d416d
build(app): remove kotlinCompilerVersion
It is deprecated now

'ComposeOptions.kotlinCompilerVersion is deprecated. Compose now uses the kotlin compiler defined in your buildscript.'

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-28 13:38:30 +05:30
82b1887f6d
app: remove identical icon
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-26 11:16:25 +05:30
dee0c54fde
app: rename UrlLauncherAmbient to appease Lint
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-26 11:16:24 +05:30
e1aa0e5bc6
app: remove customtabs dependency
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-25 19:15:51 +05:30
57a2f67646
build: pare down unnecessary Jetpack dependencies
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-25 18:58:57 +05:30
04658e99fd
MainActivity: snap to top of list when pressing hottest posts tab
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-25 18:44:00 +05:30
Aditya Wasan
7e7eff6c8e
src: use launchSingleTop to prevent adding duplicate composables
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
(cherry picked from commit 45e3bd56855570db0f449ae5dde89dd46e4f2129)
2021-01-25 17:43:00 +05:30
45c3ec504f
all: reformat
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-18 18:53:18 +05:30
19c5bac6d3
all: use Dagger Hilt VM injection
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-18 18:51:51 +05:30