Commit graph

702 commits

Author SHA1 Message Date
bors[bot]
2cb30deeda
Merge #169
169: Update to Gradle 7.0-RC1 r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-28 23:19:20 +00:00
ff3b4c7a27
api: update KSP for Gradle 7.0-RC1 support
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-29 04:20:14 +05:30
1171fb17e6
gradle: update to 7.0 RC1
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-29 04:19:50 +05:30
bors[bot]
0052312459
Merge #177
177: Bump AGP r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-26 06:45:28 +00:00
826347023b
build: bump AGP
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-26 12:01:54 +05:30
bors[bot]
f2ea2993cc
Merge #176
176: Enable R8 full mode r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-25 11:25:27 +00:00
be95d0c198
gradle: enable R8 full mode
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-25 15:37:30 +05:30
bors[bot]
f6d8d3c536
Merge #174
174: Cleanup string abstraction and switch everything to it r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-24 06:55:17 +00:00
1abbd8baba
common/app: migrate all string usages to common Strings API
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-24 11:56:52 +05:30
cad53dcce5
common: remove old string API
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-24 11:56:51 +05:30
4016c22289
app: switch to extension API
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-24 11:56:51 +05:30
56fd18be75
common: attempt extension backed string API
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-24 11:56:51 +05:30
00c1977f87
common/app: rename StringEnum to Strings
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-24 10:43:47 +05:30
b19a9267f6
common: link bug in code
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-24 10:38:44 +05:30
5783210873
app: add sun.misc.Unsafe to proguard rules
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-24 10:34:18 +05:30
f242ffb2af
common: cleanup Gradle build
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-24 10:30:45 +05:30
bors[bot]
60bf7ecde7
Merge #172
172: Abstract strings into common multiplatform library r=msfjarvis a=Skrilltrax

Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>

Co-authored-by: Aditya Wasan <adityawasan55@gmail.com>
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-23 20:03:42 +00:00
Aditya Wasan
c52f7812f1
cleanup: add newline at the end of the file
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-03-24 01:17:47 +05:30
Aditya Wasan
44d220b74c
revertme: hack to make StringValue compile
Currently compose does not support default values with actual/expect functions.
When we use vararg it creates a default emptyArray if we do not provide an argument which causes the compose compiler to throw an ISE.
We can revert this commit once https://youtrack.jetbrains.com/issue/KT-44499 is merged.

Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-03-24 01:08:29 +05:30
Aditya Wasan
13b3abdcd4
ui: use stringValue to get resources inside app module
This will not compile but still adding this so that we can revert the hack in-future and get it running correctly.

Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-03-24 01:05:43 +05:30
Aditya Wasan
282da93630
build: enable androidResources for common module
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-03-24 00:25:47 +05:30
bors[bot]
ccbcea162d
Merge #171
171: Update Jetbrains Compose and pull-to-refresh r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-23 16:40:54 +00:00
5f227b2327
build: update deps
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-23 22:02:12 +05:30
b233129c32
common: include androidMain resources directory
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-23 21:15:37 +05:30
Aditya Wasan
01ffc49e18
common: add common stringValue api
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-03-23 21:15:37 +05:30
bors[bot]
4a40192647
Merge #170
170: Add ability to change saved posts sorting order r=msfjarvis a=msfjarvis

Fixes #167

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-23 12:18:47 +00:00
08e8993101
Add tests for LobstersTopAppBar
(cherry picked from commit eee0737a1c)
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-23 17:45:54 +05:30
3be1d2ad87
Wire in sorting preference awareness
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-23 17:42:14 +05:30
1408bee041
Wire in ability to toggle sorting order
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-23 17:41:58 +05:30
9bf5ee90ef
Introduce and integrate ClawPreferences
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-23 17:40:30 +05:30
9e3f718ab9
Add DataStore dependency and set up injection
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-22 23:26:52 +05:30
bors[bot]
b37707d933
Merge #168
168: Update to AGP 7.0.0-alpha10 r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-22 16:49:48 +00:00
ae1018f8c5
build: update AGP
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-22 22:19:05 +05:30
bors[bot]
faa6fbcc39
Merge #166
166: Refactor LobstersItem r=msfjarvis a=msfjarvis

Breaks apart PostDetails into multiple individual composables and reimplements the layout logic with a more easy to understand mental model.


Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-21 19:10:24 +00:00
2b68bd82a4
LobstersItem: break avatar URL for test post
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-22 00:36:46 +05:30
88f44bd63b
app: update screenshots
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-21 22:57:28 +05:30
ced3aa44f1
Add tests for list of posts
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-21 22:57:12 +05:30
6f1a488b92
Rewrite LobstersItem
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-21 22:56:01 +05:30
bors[bot]
b229f1b1dc
Merge #164
164: Fix AVD name in emulator bootup script r=msfjarvis a=msfjarvis

It didn't fail in this repo because we stick to API 30 only but it's good to fix it anyway

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-20 13:12:24 +00:00
88a309712d
scripts/boot_emulator: dynamically set AVD name
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-20 18:41:14 +05:30
bors[bot]
3d93f9b04b
Merge #163
163: Update scripts r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-20 12:44:02 +00:00
f37682c154 scripts: import cleanups from APS
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-20 18:13:05 +05:30
bors[bot]
4cd00a4b44
Merge #162
162: Refactor LobstersItem and add a dedicated comments button r=msfjarvis a=msfjarvis

Refer to updated screenshot test for the UI changes.

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-19 12:44:59 +00:00
ce8d9f09fa
app: update screenshots
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-19 16:26:07 +05:30
82707f8347
LobstersItem: tweak paddings
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-19 16:24:05 +05:30
eae231722f
LobstersItem: tweak paddings
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-19 16:02:40 +05:30
f269c0ae08
app: rename LobstersItem parameters
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-19 15:18:22 +05:30
840361707a
LobstersItem: add a dedicated comments button
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-19 15:17:32 +05:30
dbab82c533
LobstersItem: adjust row weightage
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-19 15:04:40 +05:30
fa605f5416
LobstersItem: split details and button to separate composables
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-19 14:57:57 +05:30