6c012f93ce
fix(common): restore support for collapsing child comments
...
Fixes: 86400c352b
2024-10-09 11:46:01 +05:30
d4fffee328
Merge branch 'remember-comment-collapsed-tate'
...
* remember-comment-collapsed-tate:
feat(comments): remember comment collapsed state
2024-10-05 00:44:47 +05:30
Ruben Quadros
86400c352b
feat(comments): remember comment collapsed state
...
Remember the comment expanded/collapsed state when scrolling. Previously,
the state was remembered inside the `Node` composable. When the users scroll,
and `Node` re-composes, the state was being reset.
In this commit, we add the collapsed state into the `CommentNode`. This makes
sure that the state is retained even when the UI is re-composed.
2024-10-04 19:51:39 +05:30
0b549dde2d
chore: refresh Lint baselines
2024-10-04 12:36:48 +05:30
d50e0e99b3
fix(build): enable Compose Compiler feature flags
2024-10-02 17:08:11 +05:30
bee721d9d8
fix(build): remove deprecated ComposeOptions
2024-10-02 01:23:53 +05:30
1dfea689c6
Revert "refactor: make PostComments non-nullable"
...
This reverts commit 39e3d783cd
2024-09-16 12:34:37 +05:30
a0276c4873
Revert "fix(common): reintroduce handling for first views for comment state"
...
This reverts commit 1cbd3b5bd0
2024-09-16 12:30:37 +05:30
aa2093424c
fix(common): restore missing padding to UserProfile page
2024-09-08 21:08:30 +05:30
b0b47d98a5
fix(common): handle pluralization for unread comments note
2024-09-06 15:30:16 +05:30
d5a0bb256f
fix(build): inject test dependencies in the screenshotTest source set
2024-09-02 12:49:32 +05:30
1ebf610794
fix(common): slightly increase padding in LobstersCard
2024-09-02 12:49:32 +05:30
e317a1f4f3
feat(common): add a basic screenshot test for MonthHeader
2024-09-02 12:49:32 +05:30
ed4c573ee4
feat(common): set up for Compose screenshot testing
2024-09-02 03:02:49 +05:30
77439a5799
fix(common): correctly size spacer to match system bars
2024-08-29 23:13:26 +05:30
8224b71465
fix(common): manually roll equals/hashCode for CommentNode
...
Excludes the parent field for comparison since it can trigger cycles in some situations
Fixes COMPOSE-LOBSTERS-5G
2024-08-29 16:47:48 +05:30
bf52966772
fix(common): re-add spacer to comments page
2024-08-29 16:34:43 +05:30
dc06410fc4
fix(common): set item keys in comments page
2024-08-29 16:34:15 +05:30
1de4916c9c
feat: redesign bottom navigation bar
2024-08-28 15:17:38 +05:30
8651a4f66b
refactor: lazily query saved and read state in UI
...
Having this always be read from the UI avoids values going stale inside data models
Fixes #641
2024-08-28 13:12:31 +05:30
6f424ae2d5
fix(android): avoid triggering a refresh on saving posts
...
The underlying issue is still not resolved since work on paging has stalled out in
Store5, but this trades the bad UX of an unwanted refresh for the slightly less
bad UX of the saved state sometimes being stale.
Fixes #558
2024-08-28 12:37:57 +05:30
1cbd3b5bd0
fix(common): reintroduce handling for first views for comment state
2024-08-24 16:02:56 +05:30
renovate[bot]
f452833f6d
chore(deps): update kotlin and compose to v2.0.20 ( #635 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.jetbrains.kotlin.plugin.serialization](https://kotlinlang.org/ )
([source](https://togithub.com/JetBrains/kotlin )) | `2.0.10` -> `2.0.20`
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
| [org.jetbrains.kotlin.plugin.compose](https://kotlinlang.org/ )
([source](https://togithub.com/JetBrains/kotlin )) | `2.0.10` -> `2.0.20`
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
| [org.jetbrains.kotlin:kotlin-gradle-plugin](https://kotlinlang.org/ )
([source](https://togithub.com/JetBrains/kotlin )) | `2.0.10` -> `2.0.20`
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>JetBrains/kotlin
(org.jetbrains.kotlin.plugin.serialization)</summary>
###
[`v2.0.20`](https://togithub.com/JetBrains/kotlin/compare/v2.0.10...v2.0.20 )
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Enabled.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View the
[repository job
log](https://developer.mend.io/github/msfjarvis/compose-lobsters ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2024-08-22 18:38:00 +00:00
39e3d783cd
refactor: make PostComments non-nullable
2024-08-21 13:37:48 +05:30
c50790e4f9
refactor(common): get rid of interior mutability in CommentNode
2024-08-21 13:13:38 +05:30
d55ff24add
refactor(common): cleanup unused stuff from tree view change
...
Follows up from changes in 6223198191
2024-08-21 13:13:38 +05:30
6223198191
refactor(common): use a simpler tree view for comments
2024-08-21 01:31:54 +05:30
9c6008b36e
refactor(common): rename Comments.kt
2024-08-12 00:54:18 +05:30
45dab6d513
fix(build): compile against SDK 35
2024-08-08 03:44:03 +05:30
371780a1fd
fixup! feat(common): visually distinguish between read and unread comments
2024-07-18 16:23:20 +05:30
a53af77705
feat(common): visually distinguish between read and unread comments
2024-07-07 23:42:19 +05:30
b132410282
feat: show "Authored by" on posts when applicable
2024-06-26 21:29:41 +05:30
3a15eea2fd
Revert "fix(common): temporarily disable collapsible comments feature"
...
Doesn't fix the bug.
This reverts commit 7ae94ee2e6
2024-06-26 12:01:16 +05:30
7ae94ee2e6
fix(common): temporarily disable collapsible comments feature
2024-06-22 19:01:34 +05:30
e2bcabe4e5
chore: refresh Lint baseline
2024-06-13 20:56:45 +05:30
9610241489
fix(common): tweak LobstersCard layout to improve touch targets
2024-06-13 20:46:01 +05:30
c4aad66c03
refactor(common): move setExpanded to CommentNode
2024-06-13 20:46:01 +05:30
535624bf22
fix(deps): upgrade to Compose 1.7 betas
2024-05-30 13:04:02 +05:30
8c0734a19a
fix(build): enable Compose strong skipping mode
2024-05-30 02:02:12 +05:30
c471fee4ee
fix(build): cut over to upstream Compose Compiler
2024-05-22 02:40:24 +05:30
b12b5c800f
feat(android): add share action
2024-05-20 01:37:00 +05:30
2ce804ed90
refactor: inline ClawAppBar
2024-05-09 18:02:02 +05:30
3b044a8d23
chore: reflow UserProfile code for pedantic reasons
2024-05-09 17:54:01 +05:30
bdca0799db
fix(common): restore older link styling in user profiles
2024-05-09 17:51:06 +05:30
6f76a15ded
fix: downgrade to Compose stable
...
Fixes PP-56
Fixes PP-61
Fixes COMPOSE-LOBSTERS-3Z
Fixes COMPOSE-LOBSTERS-40
2024-05-07 14:02:08 +05:30
9fe6e34015
chore: make LaunchedEffect keys consistent
2024-05-07 13:09:30 +05:30
847858d852
fix(common): set key for comment entries
2024-05-04 04:23:28 +05:30
8735f7f8e8
fix(common): mark CommentNode#findTopMostParent as tailrec
2024-05-04 04:23:28 +05:30
54ec5a4c8d
Revert "fix: remove visual divider"
...
It's better with it
This reverts commit 687cb32f7c
2024-04-30 01:16:17 +05:30
c79b7114fb
refactor: selectively apply DAGP advice
2024-04-30 00:53:21 +05:30
