Commit graph

404 commits

Author SHA1 Message Date
ff4dfcac61
treewide: update Compose and other deps
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-12 01:54:20 +05:30
bors[bot]
d2bc068f95
Merge #74
74: BottomNavigation tweaks r=msfjarvis a=msfjarvis

Extracts the code into its own composable and slightly tweaks the UI to hide labels for inactive destinations. Blocked on #66

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-11 14:54:49 +00:00
2778c88d3a
Add bottom padding to list composables
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-11 20:17:20 +05:30
5b66b440ce
Separate out BottomNavigation to its own composable
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-11 20:17:19 +05:30
bors[bot]
7b4e8a8f68
Merge #76
76: Update dependencies r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-11 14:22:36 +00:00
587f40f79f
build: update Ktor and gradle-versions-plugin
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-11 19:51:58 +05:30
bors[bot]
3cb1c4b027
Merge #73
73: Reimplement LobstersItem to not require swipe actions r=msfjarvis a=msfjarvis

Work towards #65

TODO:
- [x] ~~Figure out why only the last tag shows in the UI~~ Fixed by using `Row` to lay it out like earlier


<details>
<summary>Screenshot</summary>

![screenshot-20201109-113553](https://user-images.githubusercontent.com/13348378/98505720-ce2a4600-227f-11eb-8342-863f2122b928.png)


</details>

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-09 06:41:07 +00:00
5678215b25
Tweak lambda parameters for LobstersItem
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-09 11:45:05 +05:30
5acab43669
Rename LobstersItemRedux to LobstersItem
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-09 11:35:42 +05:30
974076c5f1
Remove LobstersItem
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-09 11:34:55 +05:30
a4bac75d2a
Replace ConstraintLayout-backed tag list with Row
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-09 11:34:39 +05:30
a0a899f999
Make the preview look like an actual list
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-08 19:19:57 +05:30
92eecce9b0
Update KDoc
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-08 19:15:06 +05:30
a9b5521dfe
Check in a revamped LobstersPost composable
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-08 19:09:03 +05:30
be1921240a
Remove swipe actions
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-08 17:25:10 +05:30
bors[bot]
f602fe8d7d
Merge #72
72: Migrate to Ktor for network operations r=msfjarvis a=msfjarvis

~~Still a work in progress, crashes during loading right now~~ Crashes are fixed and tests were added back, good to go now.

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-08 11:35:41 +00:00
abe6c4c2b8
app: port tests to Ktor
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-08 17:04:23 +05:30
d01a7e18a2
app: tweak proguard rules to fix crash
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-08 16:44:52 +05:30
276877119d
app: reinstate API wrapper to hide client implementation
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-08 16:41:02 +05:30
5b77fdf54b
buildSrc: remove now unused dependencies
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-08 16:15:00 +05:30
b71bb9e48d
lobsters-api: remove
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-08 16:14:48 +05:30
05b5ecaa5f
app: remove LobstersApi module
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-08 16:14:27 +05:30
f7e0ba6544
app: switch to loading posts using Ktor
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-08 16:13:41 +05:30
836b5ef725
app: add Ktor client module
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-08 16:12:25 +05:30
bc7eb9abaa
idea: don't wildcard ktor imports
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-08 16:00:07 +05:30
dd177c5578
buildSrc: add Ktor dependencies
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-08 15:53:46 +05:30
03b2bbd22c
app: sort dependencies
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-08 15:44:05 +05:30
bors[bot]
8729ad9cd1
Merge #71
71: Follow up on Gradle build rewrite r=msfjarvis a=msfjarvis

Adds back a dependency that was accidentally removed, and converts `settings.gradle` to Kotlin

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-08 09:19:20 +00:00
fa9d964a32
Convert settings.gradle to Kotlin and enable Gradle metadata
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-08 14:47:57 +05:30
dc12917b66
lobsters-api: add back accidentally removed Retrofit dependency
Fixes: 84f45f523a ("Replace Moshi with kotlinx.serialization")
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-08 14:46:06 +05:30
bors[bot]
800c91c637
Merge #69
69: Replace Moshi with kotlinx.serialization r=msfjarvis a=msfjarvis

More work towards #67

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-07 05:49:58 +00:00
c3e73256bf
app: add R8 rules for kotlinx.serialization
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-07 11:18:10 +05:30
84f45f523a
Replace Moshi with kotlinx.serialization
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-07 11:15:54 +05:30
43295a58eb
build: add kotlinx.serialization dependencies
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-07 11:06:03 +05:30
bors[bot]
10630944d3
Merge #68
68: Convert Gradle build configuration to Kotlin r=msfjarvis a=msfjarvis

First steps toward #67

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-06 12:00:00 +00:00
1e2fef884f
build: convert to Gradle Kotlin DSL
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-06 17:28:26 +05:30
bors[bot]
9839bf4014
Merge #63
63: Add more tests for Lobsters API and fix okhttp version r=msfjarvis a=msfjarvis

Downgrades OkHttp back to 3.14.9 because that's what Retrofit uses and using a higher version results in test failures for me when executed through the IDE. Also adds a couple more tests for the API data, and adds a `.git-blame-ignore-revs` file to skip some noisy commits that make `git-blame` that much useless.

bors r+


Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 08:23:58 +00:00
dd680ecf70
git: add git-blame-ignored-revs file for noisy changes
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 13:51:16 +05:30
1528231032
lobsters-api: add some more tests
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 13:50:10 +05:30
6f5d88a5c1
build: downgrade OkHttp back to the retrofit version
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 13:44:00 +05:30
bors[bot]
442293215c
Merge #61
61: Revamp database setup r=msfjarvis a=msfjarvis

An assortment of database related changes

- Moved the `data` module into `app`
- Enabled schema generation for `PostsDatabase`
- Added and enabled [Roomigrant](https://github.com/MatrixDev/Roomigrant)
- Removed the now unused `LobstersPost#isLiked` field
- Bumped the database version to let Roomigrant handle the upgrade

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-01 20:22:48 +00:00
ab2ba579d1
app: bump database version
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 01:48:55 +05:30
c22ede7aa1
model: remove unused field
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 01:48:55 +05:30
bfa4cd58a7
app: setup Roomigrant
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 01:48:54 +05:30
4b5c1e6d15
app: add roomigrant dependencies
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 01:48:54 +05:30
f367c79e8e
app: turn on schema generation
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 01:48:53 +05:30
c3cead5993
data: move into app module
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 01:48:53 +05:30
bors[bot]
713706caff
Merge #60
60: Make saving a swipe action r=msfjarvis a=msfjarvis

~~This isn't ready yet, because when done we want to make this use just `Modifier.swipeable` and not actually dismiss the view.~~ Good to go now 


Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-01 20:05:40 +00:00
b84d6ac2ef
model: add back unused variable for db compat
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 01:35:00 +05:30
78f15ac7d9
Use enum for swipe states
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 01:10:19 +05:30