Commit graph

527 commits

Author SHA1 Message Date
bors[bot]
8729ad9cd1
Merge #71
71: Follow up on Gradle build rewrite r=msfjarvis a=msfjarvis

Adds back a dependency that was accidentally removed, and converts `settings.gradle` to Kotlin

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-08 09:19:20 +00:00
fa9d964a32
Convert settings.gradle to Kotlin and enable Gradle metadata
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-08 14:47:57 +05:30
dc12917b66
lobsters-api: add back accidentally removed Retrofit dependency
Fixes: 84f45f523a ("Replace Moshi with kotlinx.serialization")
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-08 14:46:06 +05:30
bors[bot]
800c91c637
Merge #69
69: Replace Moshi with kotlinx.serialization r=msfjarvis a=msfjarvis

More work towards #67

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-07 05:49:58 +00:00
c3e73256bf
app: add R8 rules for kotlinx.serialization
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-07 11:18:10 +05:30
84f45f523a
Replace Moshi with kotlinx.serialization
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-07 11:15:54 +05:30
43295a58eb
build: add kotlinx.serialization dependencies
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-07 11:06:03 +05:30
bors[bot]
10630944d3
Merge #68
68: Convert Gradle build configuration to Kotlin r=msfjarvis a=msfjarvis

First steps toward #67

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-06 12:00:00 +00:00
1e2fef884f
build: convert to Gradle Kotlin DSL
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-06 17:28:26 +05:30
bors[bot]
9839bf4014
Merge #63
63: Add more tests for Lobsters API and fix okhttp version r=msfjarvis a=msfjarvis

Downgrades OkHttp back to 3.14.9 because that's what Retrofit uses and using a higher version results in test failures for me when executed through the IDE. Also adds a couple more tests for the API data, and adds a `.git-blame-ignore-revs` file to skip some noisy commits that make `git-blame` that much useless.

bors r+


Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 08:23:58 +00:00
dd680ecf70
git: add git-blame-ignored-revs file for noisy changes
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 13:51:16 +05:30
1528231032
lobsters-api: add some more tests
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 13:50:10 +05:30
6f5d88a5c1
build: downgrade OkHttp back to the retrofit version
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 13:44:00 +05:30
bors[bot]
442293215c
Merge #61
61: Revamp database setup r=msfjarvis a=msfjarvis

An assortment of database related changes

- Moved the `data` module into `app`
- Enabled schema generation for `PostsDatabase`
- Added and enabled [Roomigrant](https://github.com/MatrixDev/Roomigrant)
- Removed the now unused `LobstersPost#isLiked` field
- Bumped the database version to let Roomigrant handle the upgrade

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-01 20:22:48 +00:00
ab2ba579d1
app: bump database version
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 01:48:55 +05:30
c22ede7aa1
model: remove unused field
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 01:48:55 +05:30
bfa4cd58a7
app: setup Roomigrant
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 01:48:54 +05:30
4b5c1e6d15
app: add roomigrant dependencies
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 01:48:54 +05:30
f367c79e8e
app: turn on schema generation
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 01:48:53 +05:30
c3cead5993
data: move into app module
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 01:48:53 +05:30
bors[bot]
713706caff
Merge #60
60: Make saving a swipe action r=msfjarvis a=msfjarvis

~~This isn't ready yet, because when done we want to make this use just `Modifier.swipeable` and not actually dismiss the view.~~ Good to go now 


Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-01 20:05:40 +00:00
b84d6ac2ef
model: add back unused variable for db compat
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 01:35:00 +05:30
78f15ac7d9
Use enum for swipe states
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 01:10:19 +05:30
3f223f4306
Remove liked post coloring from UI
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 01:07:12 +05:30
a52c75601c
Switch to Modifier.swipeable
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 01:03:54 +05:30
8c162c75c5
Make saving a swipe dismiss action
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 00:41:08 +05:30
bors[bot]
bb8c07f232
Merge #59
59: Reorganize classes based on Buffer's package structure r=msfjarvis a=msfjarvis

Following the overview from [this post](https://buffer.com/resources/android-rethinking-package-structure/). I personally find myself agreeing with the reasoning behind these changes and can see the benefits.

bors r+


Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-01 18:01:48 +00:00
3d117362ef
app: restructure files based on Buffer's package structure
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-01 23:29:08 +05:30
bors[bot]
023601fd09
Merge #58
58: Fix Jetpack Compose link r=msfjarvis a=rleppink

The current link does not resolve because of the double `https://`

Co-authored-by: Ronald Leppink <rleppink@users.noreply.github.com>
2020-10-31 16:01:02 +00:00
Ronald Leppink
5b1c7cbf5c
Fix Jetpack Compose link
The current link does not resolve because of the double `https://`
2020-10-31 16:51:24 +01:00
bors[bot]
4f2c5b1909
Merge #57
57: Prepare for testing r=msfjarvis a=msfjarvis

Work towards #56

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-30 09:18:43 +00:00
779ad2f8b9
Make UrlLauncher a fun interface
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-30 14:47:47 +05:30
b195c0d203
Make bottom nav icons part of destination classes
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-30 14:22:16 +05:30
41521cca95
Persist hottest list scroll state across navigation events
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-30 14:16:09 +05:30
108a28384c
Extract viewModel references out of post list composables
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-30 14:11:25 +05:30
bors[bot]
b641cab624
Merge #55
55: Only navigate when not on the current screen r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-29 12:10:19 +00:00
b031d36fa2
Only navigate when not on the current screen
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-29 17:09:27 +05:30
bors[bot]
97dc62afe1
Merge #54
54: Cleanup and reformat r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-29 11:29:57 +00:00
e37d71fba6
Move hardcoded strings to resources
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-29 16:53:03 +05:30
1be10010c8
app: reformat XML resources
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-29 16:48:21 +05:30
cec0e1bbcb
gradle: reformat all build files with 2SI
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-29 16:38:01 +05:30
7c4e4aea26
Remove unused variable
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-29 16:35:14 +05:30
bors[bot]
60f6108d35
Merge #53
53: Fix pagination and extract UrlLauncherAmbient r=msfjarvis a=msfjarvis

Our pagination hack currently does not update the last index field which has now been fixed. While here we also take the time to extract UrlLauncherAmbient and prepare the post list composables for tweaking from the root UI

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-29 11:01:46 +00:00
43fb668c7d
ui: Add Modifier params to [Hottest|Saved]Posts composables
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-29 16:27:12 +05:30
ca77d3cf2a
Move our UrlLauncherAmbient to individual composables
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-29 16:25:12 +05:30
906cfb5e43
Fix pagination
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-29 16:22:10 +05:30
bors[bot]
20a38c662e
Merge #52
52: Switch to BottomNav and use AndroidX navigation r=msfjarvis a=msfjarvis

This couldn't have been any easier to implement. Everything worked in the very first try, just amazing, amazing work from the Compose and Navigation teams.

bors r+


Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-29 09:33:17 +00:00
1aa0934104
Switch to BottomNav backed by AndroidX navigation
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-29 14:59:54 +05:30
415d9e075d
build: upgrade accompanist
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-29 14:57:30 +05:30
df74ff587a
build: add navigation-compose
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-29 14:18:54 +05:30