764be07cc0
fix: address regression in comment collapse
2025-06-02 21:52:19 +05:30
8947c3a3bc
refactor: make CommentNode#toString
non-recursive
2025-06-02 21:40:46 +05:30
7c9f833ade
refactor: pull down comments stuff into common
2025-06-01 14:40:43 +05:30
0d47787a73
refactor: remove unused method
2025-06-01 13:49:30 +05:30
8c4b2f2b9b
refactor: move comment expand/collapse flow to a button
2025-06-01 13:36:04 +05:30
b6169ca5ca
fix: add extra offset to comment counts when required
2025-05-30 00:47:28 +05:30
bebbe4f82c
fix: key ViewModels to prevent incorrect re-use
2025-05-29 23:45:37 +05:30
bcac86d187
refactor: hoist state out of comments page
2025-05-26 19:14:23 +05:30
0d3c08c10a
refactor: hoist state out of UserProfile
...
Solves the issue of every pop of the backstack causing data to be re-fetched,
but now has the issue of the data being stale for a few frames. Still better
than the current state, so I'll take it.
2025-05-26 19:02:37 +05:30
5d65d1ea51
common: make NetworkState
public
2025-05-26 18:52:55 +05:30
be80812dc6
refactor: rewrite comment text rendering
2025-05-25 08:46:00 +05:30
82d8303bfe
chore(deps): bump everything
2025-03-28 23:42:39 +05:30
d47098d019
refactor(common): improve multipreview annotations
2025-02-16 18:57:23 +05:30
Devon Sawatsky
bb11ede32a
fix: rename updatedAt field to lastEditedAt for comments
2025-02-14 04:51:38 +05:30
bff573ec10
Partially revert "fix(api): refresh post details golden snapshot"
...
There's a more complete patch available from the person who filed the issue
This partially reverts commit e81e28c395
.
2025-02-14 04:51:11 +05:30
e81e28c395
fix(api): refresh post details golden snapshot
...
Fixes #775
2025-02-14 03:26:58 +05:30
25249629fd
chore: remove years from license headers
...
These are a useless annoyance
See: https://daniel.haxx.se/blog/2023/01/08/copyright-without-years/
2025-01-23 23:45:10 +05:30
renovate[bot]
4a9236e7c2
fix(deps): update dependency androidx.compose:compose-bom-alpha to v2025 ( #759 )
...
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[androidx.compose:compose-bom-alpha](https://developer.android.com/jetpack )
| `2024.12.01` -> `2025.01.00` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Enabled.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR was generated by [Mend Renovate](https://mend.io/renovate/ ).
View the [repository job
log](https://developer.mend.io/github/msfjarvis/compose-lobsters ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMDcuMCIsInVwZGF0ZWRJblZlciI6IjM5LjEwNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2025-01-18 22:11:03 +00:00
5a7e178c6d
fix(deps): update richtext to v1.0.0-alpha02
2024-12-09 16:07:26 +05:30
5db68ba186
feat: highlight story author in comments
2024-11-14 01:21:03 +05:30
f00853dcc4
fix(comments): preserve scroll state
2024-11-13 01:00:07 +05:30
103f495ee1
fix: tweak Coil cache configuration
...
Reduce in-memory cache size and provide a bigger disk cache instead
2024-11-05 13:13:59 +05:30
b24a180780
refactor: migrate to Coil3
2024-11-05 13:13:59 +05:30
ThanaReka
b84f266db7
Add tablet specific UI ( #686 )
...
Hi @msfjarvis ! Please have a look at what I have been able to implement
so far. When trying to call the ListDetail version in the MainActivity I
realized that the MainActivity is based on the BaseActivity class, and I
wasn't exactly sure how to set the parameters for ListDetail. Let me
know your thoughts when you get a chance. Thanks!
---------
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2024-10-26 20:53:43 +00:00
6c012f93ce
fix(common): restore support for collapsing child comments
...
Fixes: 86400c352b
("feat(comments): remember comment collapsed state")
2024-10-09 11:46:01 +05:30
Ruben Quadros
86400c352b
feat(comments): remember comment collapsed state
...
Remember the comment expanded/collapsed state when scrolling. Previously,
the state was remembered inside the `Node` composable. When the users scroll,
and `Node` re-composes, the state was being reset.
In this commit, we add the collapsed state into the `CommentNode`. This makes
sure that the state is retained even when the UI is re-composed.
2024-10-04 19:51:39 +05:30
1dfea689c6
Revert "refactor: make PostComments non-nullable"
...
This reverts commit 39e3d783cd
.
2024-09-16 12:34:37 +05:30
a0276c4873
Revert "fix(common): reintroduce handling for first views for comment state"
...
This reverts commit 1cbd3b5bd0
.
2024-09-16 12:30:37 +05:30
aa2093424c
fix(common): restore missing padding to UserProfile page
2024-09-08 21:08:30 +05:30
b0b47d98a5
fix(common): handle pluralization for unread comments note
2024-09-06 15:30:16 +05:30
1ebf610794
fix(common): slightly increase padding in LobstersCard
2024-09-02 12:49:32 +05:30
77439a5799
fix(common): correctly size spacer to match system bars
2024-08-29 23:13:26 +05:30
8224b71465
fix(common): manually roll equals/hashCode for CommentNode
...
Excludes the parent field for comparison since it can trigger cycles in some situations
Fixes COMPOSE-LOBSTERS-5G
2024-08-29 16:47:48 +05:30
bf52966772
fix(common): re-add spacer to comments page
2024-08-29 16:34:43 +05:30
dc06410fc4
fix(common): set item keys in comments page
2024-08-29 16:34:15 +05:30
1de4916c9c
feat: redesign bottom navigation bar
2024-08-28 15:17:38 +05:30
8651a4f66b
refactor: lazily query saved and read state in UI
...
Having this always be read from the UI avoids values going stale inside data models
Fixes #641
2024-08-28 13:12:31 +05:30
6f424ae2d5
fix(android): avoid triggering a refresh on saving posts
...
The underlying issue is still not resolved since work on paging has stalled out in
Store5, but this trades the bad UX of an unwanted refresh for the slightly less
bad UX of the saved state sometimes being stale.
Fixes #558
2024-08-28 12:37:57 +05:30
1cbd3b5bd0
fix(common): reintroduce handling for first views for comment state
2024-08-24 16:02:56 +05:30
39e3d783cd
refactor: make PostComments non-nullable
2024-08-21 13:37:48 +05:30
c50790e4f9
refactor(common): get rid of interior mutability in CommentNode
2024-08-21 13:13:38 +05:30
d55ff24add
refactor(common): cleanup unused stuff from tree view change
...
Follows up from changes in 6223198191
2024-08-21 13:13:38 +05:30
6223198191
refactor(common): use a simpler tree view for comments
2024-08-21 01:31:54 +05:30
9c6008b36e
refactor(common): rename Comments.kt
2024-08-12 00:54:18 +05:30
45dab6d513
fix(build): compile against SDK 35
2024-08-08 03:44:03 +05:30
371780a1fd
fixup! feat(common): visually distinguish between read and unread comments
2024-07-18 16:23:20 +05:30
a53af77705
feat(common): visually distinguish between read and unread comments
2024-07-07 23:42:19 +05:30
b132410282
feat: show "Authored by" on posts when applicable
2024-06-26 21:29:41 +05:30
3a15eea2fd
Revert "fix(common): temporarily disable collapsible comments feature"
...
Doesn't fix the bug.
This reverts commit 7ae94ee2e6
.
2024-06-26 12:01:16 +05:30
7ae94ee2e6
fix(common): temporarily disable collapsible comments feature
2024-06-22 19:01:34 +05:30