msfjarvis/compose-lobsters
1
Fork 0
mirror of https://github.com/msfjarvis/compose-lobsters synced 2025-08-17 21:27:01 +05:30
Code Issues Projects Releases Packages Wiki Activity Actions
521 commits 5 branches 56 tags 28 MiB
Commit graph

521 commits

This branch
This branch
All branches
Author SHA1 Message Date
Harsh Shandilya
875e4ea32c
Revert "LobstersApp: replace with a BackgroundScaffold" 
This reverts commit be58017cac.
 2021-02-20 13:58:05 +05:30
Harsh Shandilya
72d51d5c52
Revert "app: remove now uneeded navigation code" 
This reverts commit 41c64f4b02.
 2021-02-20 13:58:01 +05:30
bors[bot]
3d5ad28eb0
Merge #112 
112: Update dependencies r=msfjarvis a=msfjarvis

bors r+
🤖

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-19 04:35:07 +00:00
Harsh Shandilya
7bb8c5b8f4
build: update AGP, MoshiX and JUnit 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-19 10:04:05 +05:30
bors[bot]
a917917166
Merge #111 
111: Switch to BackdropScaffold for the main screen r=msfjarvis a=msfjarvis

This is peak fanciness, we can't do any better

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-16 18:57:27 +00:00
Harsh Shandilya
5c39c481b7
app: add proguard rules for release builds 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-17 00:25:41 +05:30
Harsh Shandilya
66a2e9ef69
BaseProjectConfig: properly register clean task 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-17 00:15:19 +05:30
Harsh Shandilya
41c64f4b02
app: remove now uneeded navigation code 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-17 00:11:48 +05:30
Harsh Shandilya
be58017cac
LobstersApp: replace with a BackgroundScaffold 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-17 00:10:28 +05:30
Harsh Shandilya
d82228483d
main: split out LobstersApp 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-16 23:54:16 +05:30
bors[bot]
8f249ec2a2
Merge #110 
110: Shorten Gradle project name r=msfjarvis a=msfjarvis

Just takes less horizontal space in the tree so what the hell

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-15 03:26:22 +00:00
Harsh Shandilya
5815afafb7
gradle: shorten project name 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-14 18:42:29 +05:30
bors[bot]
6fd45a2608
Merge #109 
109: Misc cleanups r=msfjarvis a=msfjarvis

bors r+
🤖

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-14 12:54:09 +00:00
Harsh Shandilya
f30fd72778
app: remove unused methods 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-14 18:23:26 +05:30
Harsh Shandilya
b455724b1c
build: cleanup Plugin declarations 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-14 18:23:26 +05:30
bors[bot]
ddafaa60eb
Merge #108 
108: Update AGP and cleanup formatting rules r=msfjarvis a=msfjarvis

bors r+
🤖

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-14 12:27:14 +00:00
Harsh Shandilya
9bf7a97e55
buildSrc: codestyle fixups 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-14 17:47:02 +05:30
Harsh Shandilya
7afff19fce
build: update AGP 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-14 17:33:30 +05:30
bors[bot]
9f88bf15ab
Merge #106 
106: Decouple navigation from UI composables r=msfjarvis a=Skrilltrax

Navigation library recommends to decouple the navigation from the composables. They specially points to pass lambdas instead of passing the NavController directly.

https://developer.android.com/jetpack/compose/navigation#testing

Co-authored-by: Aditya Wasan <adityawasan55@gmail.com>
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-12 08:20:28 +00:00
Aditya Wasan
25b3ad4f8e
Add test for BottomNavigationLayout 
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
 2021-02-12 13:24:38 +05:30
Harsh Shandilya
91cfb0b2d2
github: prep for running instrumentation tests 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-12 11:33:47 +05:30
Harsh Shandilya
7da2cfd456
buildSrc: exclude duplicate license file from packaging 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-12 11:33:37 +05:30
Harsh Shandilya
97eaf20dbc
build(app): add compose testing dependencies 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-12 11:33:23 +05:30
Harsh Shandilya
aff52e7d5f
all: reformat 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-11 16:46:50 +05:30
Aditya Wasan
1a6174b1c8
fix typo 2021-02-11 16:45:51 +05:30
Harsh Shandilya
98866ee407
Simplify getDestinationFromRoute 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-11 16:45:50 +05:30
Aditya Wasan
703957e2b7
navigation: do not pass navController to composables 
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
 2021-02-11 16:45:50 +05:30
bors[bot]
baada58e8c
Merge #107 
107: Update dependencies r=msfjarvis a=msfjarvis

bors r+
🤖

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-11 10:59:21 +00:00
Harsh Shandilya
885c2a5865
build: upgrade to Compose 1.0.0-alpha12 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-11 16:28:34 +05:30
Harsh Shandilya
5fef8a4d51
build: replace JCenter with MavenCentral and drop JitPack 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-11 16:28:10 +05:30
bors[bot]
40c4c425f6
Merge #105 
105: Upgrade to Dagger 2.32 r=msfjarvis a=msfjarvis

bors r+
🤖

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-09 09:39:30 +00:00
Harsh Shandilya
c0e0e53ee7 build: upgrade to Dagger 2.32 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-09 15:08:22 +05:30
Harsh Shandilya
2029ceeee0
build: upgrade to Dagger 2.32 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-09 15:08:01 +05:30
bors[bot]
a9999aae2e
Merge #104 
104: Add icons for IDE project list r=msfjarvis a=msfjarvis

bors r+
🤖

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-08 08:57:05 +00:00
Harsh Shandilya
b5a4787424
idea: add icons 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-08 14:21:58 +05:30
bors[bot]
2b39717cab
Merge #103 
103: Dependency updates r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-08 08:45:46 +00:00
Harsh Shandilya
8f53a39f63
build: upgrade kotlin 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-08 14:14:45 +05:30
Harsh Shandilya
020976e257
build: update remaining dependencies 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-08 14:14:44 +05:30
Harsh Shandilya
cdfa20b9a7
build: upgrade to Compose alpha11 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-08 14:14:43 +05:30
Harsh Shandilya
b87e242de2
build: remove gradle-versions-plugin 
I use a Gradle init script for this now

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-08 13:13:02 +05:30
bors[bot]
147f2d23a5
Merge #101 
101: Fix cache issues r=msfjarvis a=Skrilltrax



Co-authored-by: Aditya Wasan <adityawasan55@gmail.com>
 2021-02-05 10:38:39 +00:00
Aditya Wasan
0fcf584b01
src: make LobstersRepository a singleton 
Earlier both LobstersViewModel and LobstersPagingSource were getting a different instance of LobstersRepository.
This lead to cache issues where LobstersPagingSource filled the cache but it was not available to the LobstersViewModel.

Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
 2021-02-05 15:00:23 +05:30
bors[bot]
43361b3a2a
Merge #102 
102: Gradle build improvements r=msfjarvis a=msfjarvis


- Cleans up unnecessary dependencies
- Skips configuring Dagger on modules where it's not needed
- Hacks together a way to load buildSrc plugin dependencies from Kotlin sources

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-01 13:14:30 +00:00
Harsh Shandilya
df1db3d0ff
buildSrc: move plugin dependencies to Dependencies.kt 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-01 18:43:52 +05:30
Harsh Shandilya
2a4c58a680
buildSrc: conditionally configure Dagger and disable kapt in tests 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-01 18:32:47 +05:30
Harsh Shandilya
0c1b20d3e7
buildSrc: remove unneeded AGP builder dependencies 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2021-02-01 18:25:30 +05:30
Aditya Wasan
9ce33bba75
src: add isCacheReady to let users know cache status 
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
 2021-01-31 23:02:16 +05:30
bors[bot]
23ec6ea9b1
Merge #75 
75: Use SQLDelight instead of Room r=msfjarvis a=Skrilltrax

Deletes all the existing Room database code and replaces it with a simplified SQLDelight-backed implementation ready for Kotlin Multiplatform.

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
Co-authored-by: Aditya Wasan <adityawasan55@gmail.com>
 2021-01-31 15:16:14 +00:00
Aditya Wasan
1946b1c333
build: remove ExperimentalStdlibApi compiler flag 
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
 2021-01-31 19:13:58 +05:30
Aditya Wasan
1251ae3bc0
src: remove is_saved from LobstersPost and fix tests 
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
 2021-01-31 18:49:49 +05:30