msfjarvis/compose-lobsters
1
Fork 0
mirror of https://github.com/msfjarvis/compose-lobsters synced 2025-08-20 12:18:44 +05:30
Code Issues Projects Releases Packages Wiki Activity Actions 2
488 commits 5 branches 56 tags 29 MiB
Commit graph

488 commits

This branch
This branch
All branches
Author SHA1 Message Date
Harsh Shandilya
abe6c4c2b8
 		app: port tests to Ktor 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-08 17:04:23 +05:30
Harsh Shandilya
d01a7e18a2
 		app: tweak proguard rules to fix crash 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-08 16:44:52 +05:30
Harsh Shandilya
276877119d
 		app: reinstate API wrapper to hide client implementation 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-08 16:41:02 +05:30
Harsh Shandilya
5b77fdf54b
 		buildSrc: remove now unused dependencies 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-08 16:15:00 +05:30
Harsh Shandilya
b71bb9e48d
 		lobsters-api: remove 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-08 16:14:48 +05:30
Harsh Shandilya
05b5ecaa5f
 		app: remove LobstersApi module 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-08 16:14:27 +05:30
Harsh Shandilya
f7e0ba6544
 		app: switch to loading posts using Ktor 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-08 16:13:41 +05:30
Harsh Shandilya
836b5ef725
 		app: add Ktor client module 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-08 16:12:25 +05:30
Harsh Shandilya
bc7eb9abaa
 		idea: don't wildcard ktor imports 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-08 16:00:07 +05:30
Harsh Shandilya
dd177c5578
 		buildSrc: add Ktor dependencies 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-08 15:53:46 +05:30
Harsh Shandilya
03b2bbd22c
 		app: sort dependencies 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-08 15:44:05 +05:30
bors[bot]
8729ad9cd1
 		Merge #71 
71: Follow up on Gradle build rewrite r=msfjarvis a=msfjarvis

Adds back a dependency that was accidentally removed, and converts `settings.gradle` to Kotlin

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-08 09:19:20 +00:00
Harsh Shandilya
fa9d964a32
 		Convert settings.gradle to Kotlin and enable Gradle metadata 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-08 14:47:57 +05:30
Harsh Shandilya
dc12917b66
 		lobsters-api: add back accidentally removed Retrofit dependency 
Fixes: 84f45f523a ("Replace Moshi with kotlinx.serialization")
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-08 14:46:06 +05:30
bors[bot]
800c91c637
 		Merge #69 
69: Replace Moshi with kotlinx.serialization r=msfjarvis a=msfjarvis

More work towards #67

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-07 05:49:58 +00:00
Harsh Shandilya
c3e73256bf
 		app: add R8 rules for kotlinx.serialization 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-07 11:18:10 +05:30
Harsh Shandilya
84f45f523a
 		Replace Moshi with kotlinx.serialization 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-07 11:15:54 +05:30
Harsh Shandilya
43295a58eb
 		build: add kotlinx.serialization dependencies 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-07 11:06:03 +05:30
bors[bot]
10630944d3
 		Merge #68 
68: Convert Gradle build configuration to Kotlin r=msfjarvis a=msfjarvis

First steps toward #67

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-06 12:00:00 +00:00
Harsh Shandilya
1e2fef884f
 		build: convert to Gradle Kotlin DSL 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-06 17:28:26 +05:30
bors[bot]
9839bf4014
 		Merge #63 
63: Add more tests for Lobsters API and fix okhttp version r=msfjarvis a=msfjarvis

Downgrades OkHttp back to 3.14.9 because that's what Retrofit uses and using a higher version results in test failures for me when executed through the IDE. Also adds a couple more tests for the API data, and adds a `.git-blame-ignore-revs` file to skip some noisy commits that make `git-blame` that much useless.

bors r+


Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-02 08:23:58 +00:00
Harsh Shandilya
dd680ecf70
 		git: add git-blame-ignored-revs file for noisy changes 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-02 13:51:16 +05:30
Harsh Shandilya
1528231032
 		lobsters-api: add some more tests 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-02 13:50:10 +05:30
Harsh Shandilya
6f5d88a5c1
 		build: downgrade OkHttp back to the retrofit version 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-02 13:44:00 +05:30
bors[bot]
442293215c
 		Merge #61 
61: Revamp database setup r=msfjarvis a=msfjarvis

An assortment of database related changes

- Moved the `data` module into `app`
- Enabled schema generation for `PostsDatabase`
- Added and enabled [Roomigrant](https://github.com/MatrixDev/Roomigrant)
- Removed the now unused `LobstersPost#isLiked` field
- Bumped the database version to let Roomigrant handle the upgrade

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-01 20:22:48 +00:00
Harsh Shandilya
ab2ba579d1
 		app: bump database version 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-02 01:48:55 +05:30
Harsh Shandilya
c22ede7aa1
 		model: remove unused field 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-02 01:48:55 +05:30
Harsh Shandilya
bfa4cd58a7
 		app: setup Roomigrant 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-02 01:48:54 +05:30
Harsh Shandilya
4b5c1e6d15
 		app: add roomigrant dependencies 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-02 01:48:54 +05:30
Harsh Shandilya
f367c79e8e
 		app: turn on schema generation 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-02 01:48:53 +05:30
Harsh Shandilya
c3cead5993
 		data: move into app module 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-02 01:48:53 +05:30
bors[bot]
713706caff
 		Merge #60 
60: Make saving a swipe action r=msfjarvis a=msfjarvis

~~This isn't ready yet, because when done we want to make this use just `Modifier.swipeable` and not actually dismiss the view.~~ Good to go now 


Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-01 20:05:40 +00:00
Harsh Shandilya
b84d6ac2ef
 		model: add back unused variable for db compat 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-02 01:35:00 +05:30
Harsh Shandilya
78f15ac7d9
 		Use enum for swipe states 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-02 01:10:19 +05:30
Harsh Shandilya
3f223f4306
 		Remove liked post coloring from UI 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-02 01:07:12 +05:30
Harsh Shandilya
a52c75601c
 		Switch to Modifier.swipeable 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-02 01:03:54 +05:30
Harsh Shandilya
8c162c75c5
 		Make saving a swipe dismiss action 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-02 00:41:08 +05:30
bors[bot]
bb8c07f232
 		Merge #59 
59: Reorganize classes based on Buffer's package structure r=msfjarvis a=msfjarvis

Following the overview from [this post](https://buffer.com/resources/android-rethinking-package-structure/). I personally find myself agreeing with the reasoning behind these changes and can see the benefits.

bors r+


Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-01 18:01:48 +00:00
Harsh Shandilya
3d117362ef
 		app: restructure files based on Buffer's package structure 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-11-01 23:29:08 +05:30
bors[bot]
023601fd09
 		Merge #58 
58: Fix Jetpack Compose link r=msfjarvis a=rleppink

The current link does not resolve because of the double `https://`

Co-authored-by: Ronald Leppink <rleppink@users.noreply.github.com>
 2020-10-31 16:01:02 +00:00
Ronald Leppink
5b1c7cbf5c
 		Fix Jetpack Compose link 
The current link does not resolve because of the double `https://`
 2020-10-31 16:51:24 +01:00
bors[bot]
4f2c5b1909
 		Merge #57 
57: Prepare for testing r=msfjarvis a=msfjarvis

Work towards #56

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-10-30 09:18:43 +00:00
Harsh Shandilya
779ad2f8b9
 		Make UrlLauncher a fun interface 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-10-30 14:47:47 +05:30
Harsh Shandilya
b195c0d203
 		Make bottom nav icons part of destination classes 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-10-30 14:22:16 +05:30
Harsh Shandilya
41521cca95
 		Persist hottest list scroll state across navigation events 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-10-30 14:16:09 +05:30
Harsh Shandilya
108a28384c
 		Extract viewModel references out of post list composables 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-10-30 14:11:25 +05:30
bors[bot]
b641cab624
 		Merge #55 
55: Only navigate when not on the current screen r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-10-29 12:10:19 +00:00
Harsh Shandilya
b031d36fa2
 		Only navigate when not on the current screen 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-10-29 17:09:27 +05:30
bors[bot]
97dc62afe1
 		Merge #54 
54: Cleanup and reformat r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-10-29 11:29:57 +00:00
Harsh Shandilya
e37d71fba6
 		Move hardcoded strings to resources 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-10-29 16:53:03 +05:30