78484de959
Merge pull request #36 from msfjarvis/custom-tabs-update
2020-10-03 02:19:48 +05:30
829a6bbdc6
UrlLauncherImpl: use AndroidX Browser methods to launch custom tab
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-03 02:08:22 +05:30
f71bd27a03
Merge pull request #35 from msfjarvis/update-followups
2020-10-03 02:08:10 +05:30
89aeb66a96
LobstersItem: replace ListItem with Column
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-03 01:59:26 +05:30
a4eb6b3cb3
Merge pull request #34 from msfjarvis/dependency-updates
2020-10-02 13:20:25 +05:30
a2eb97e504
build: update all dependencies
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-02 04:40:59 +05:30
bab3a53a53
Merge pull request #32 from msfjarvis/first-load
...
Clear local cache of posts on first load
2020-09-28 11:07:15 +05:30
837970147c
app: add local cache busting
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-28 11:03:32 +05:30
probot-auto-merge[bot]
0ecf21467b
Merge pull request #31 from msfjarvis/offline-cache
...
Set up offline caching and no posts state
2020-09-27 11:44:40 +00:00
62c2cb3fb7
app: add no posts state
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-27 16:44:39 +05:30
4fdb5a60d5
app: wire in local persistence in LobstersViewModel
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-27 16:24:36 +05:30
95334d2c8b
data: ignore overwriting when inserting posts
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-27 16:23:41 +05:30
probot-auto-merge[bot]
6867d84ca9
Merge pull request #27 from msfjarvis/comments
...
Add comment open action and cleanup unused code
2020-09-27 09:05:19 +00:00
baddf7e763
app: remove unused resources
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-27 14:29:04 +05:30
c21a2bf13a
app: add comment open action
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-27 14:14:12 +05:30
ac336efa33
app: restrict tags to just the first 4
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-27 14:08:41 +05:30
52e010d79b
app: remove unnecessary Column from LobstersItem
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-27 14:00:26 +05:30
91205a0b2a
data: cleanup unused code
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-27 13:42:39 +05:30
probot-auto-merge[bot]
a510565324
Merge pull request #26 from msfjarvis/leaky-abstractions
...
Cure a case of leaky abstractions with sad indirection
2020-09-27 05:02:55 +00:00
3693bc39f4
model: remove Room annotations and unused dependencies
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-27 10:28:36 +05:30
aa7a732cce
data: wrap LobstersPost into an intermediate entity
...
This lets us keep the same database structure without needing to leak Room-specific properties into our model
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-27 10:28:22 +05:30
8d4535d6bf
build: uprev to Gradle 6.7 RC2
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-27 10:24:27 +05:30
probot-auto-merge[bot]
d6b4f2c682
Merge pull request #25 from msfjarvis/ui-work
...
Perf and UX improvements
2020-09-25 09:40:37 +00:00
1ba1701574
app: rewrite UrlLauncherImpl to use Chrome Custom Tabs
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-25 15:05:52 +05:30
b30ab6a537
Revert "app: use ConstraintLayout for laying out LobstersItem"
...
Won't solve the problem I was hoping to solve.
This reverts commit a14484583d
2020-09-25 14:35:10 +05:30
8462e5c763
app: pass --user 0 to ADB when installing
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-25 12:10:55 +05:30
0db3502855
build: use release signing for debug builds as well
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-25 02:36:14 +05:30
c300a85204
Merge pull request #24 from msfjarvis/ui-improvements
2020-09-25 02:35:05 +05:30
a14484583d
app: use ConstraintLayout for laying out LobstersItem
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-25 02:25:47 +05:30
b68eda3051
app: tweak padding for tags and add border
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-25 02:04:33 +05:30
36804a43bc
app: re-enable preview for LobstersItem
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-25 01:55:01 +05:30
2f70acd5d0
Merge pull request #23 from msfjarvis/row-ui-tweaks
...
Use consistent vertical padding
2020-09-24 05:08:42 +05:30
2d649d70be
app: use consistent vertical padding and reword submitter text
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-24 04:47:56 +05:30
7b42915a1b
Merge pull request #22 from msfjarvis/pagination-prep
2020-09-23 22:17:13 +05:30
590bd2dfd8
app: enable kotlinx.coroutines.ExperimentalCoroutinesApi for entire module
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-23 22:14:20 +05:30
22abaa15c2
model: add default value for submitter karma
...
The API sometimes doesn't pass this value
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-23 22:09:15 +05:30
e1c9b34bbe
app: setup pagination and a viewmodel for posts
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-23 22:06:56 +05:30
5260f454ef
build: add lifecycle-viewmodel-ktx
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-23 21:35:53 +05:30
b3ee3f44c4
build: commonize application of kotlin-android plugin
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-23 17:19:11 +05:30
64ac515ed0
build: force correct coroutines and kotlin-reflect artifacts
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-23 17:19:10 +05:30
29e72da327
app: add persistence module
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-23 17:19:10 +05:30
96c25c428d
data: add database for lobsters posts
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-23 17:19:10 +05:30
699a475315
app: use lifecycleScope for fetching posts
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-23 17:19:09 +05:30
e7860e4f55
api: add support for pagination
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-23 17:19:09 +05:30
probot-auto-merge[bot]
93985ee02d
Merge pull request #21 from msfjarvis/rewire-api
...
Use retrofit suspend support to hide implementation details of API
2020-09-23 09:04:15 +00:00
0806d71e96
lobsters-api: fix tests
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-23 14:32:01 +05:30
a66186adc3
all: use retrofit suspend support to hide implementation details of API
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-23 13:48:37 +05:30
a3b1e02783
Merge pull request #20 from msfjarvis/pivot-to-lobsters
2020-09-23 04:03:26 +05:30
4a507e4d79
all: cleanup
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-23 04:00:57 +05:30
8808e0dfb8
github: only run unit tests in CI
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-23 03:58:45 +05:30
