From 4df480ad493a73d36baf16b39600619be0c23c1a Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Wed, 16 Nov 2022 12:03:31 +0530 Subject: [PATCH] fix(netlify): use correct status codes in error response Also clean up an unnecessary log statement --- netlify/edge-functions/webfinger/webfinger.ts | 24 +++++++++++++------ 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/netlify/edge-functions/webfinger/webfinger.ts b/netlify/edge-functions/webfinger/webfinger.ts index 0d46bf9..4f6bccd 100755 --- a/netlify/edge-functions/webfinger/webfinger.ts +++ b/netlify/edge-functions/webfinger/webfinger.ts @@ -1,13 +1,18 @@ +import { Status } from "https://deno.land/std@0.136.0/http/http_status.ts"; import type { Context } from "https://edge.netlify.com"; export default async (request: Request, context: Context) => { const url = new URL(request.url); const resourceParam = url.searchParams.get("resource"); - context.log(`resourceParam=${resourceParam}`); if (resourceParam === null) { - return context.json({ - error: "No 'resource' query parameter was provided", - }); + return context.json( + { + error: "No 'resource' query parameter was provided", + }, + { + status: Status.BadRequest, + } + ); } else { const re = /acct:(.*)@msfjarvis.dev/; if (resourceParam.match(re) !== null) { @@ -36,9 +41,14 @@ export default async (request: Request, context: Context) => { ], }); } else { - return context.json({ - error: "This domain only works for @msfjarvis.dev requests", - }); + return context.json( + { + error: "This domain only works for @msfjarvis.dev requests", + }, + { + status: Status.BadRequest, + } + ); } } };