msfjarvis/compose-lobsters
1
Fork 0
mirror of https://github.com/msfjarvis/compose-lobsters synced 2025-08-14 18:47:03 +05:30
Code Issues Projects Releases Packages Wiki Activity Actions 4

refactor(common): workaround false-positive MagicNumber lint

Browse source
This commit is contained in:
Harsh Shandilya 2022-10-03 12:57:28 +05:30
parent 8f927613f3
commit 069d7e5e05
No known key found for this signature in database
2 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
common/src/main/kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt
View file

@ -180,7 +180,7 @@ fun CommentsButton(
badge = { badge = {
if (commentCount != null) { if (commentCount != null) {
Badge( Badge(
modifier = Modifier.absoluteOffset(x = (-8).dp), modifier = Modifier.absoluteOffset(x = -(8.dp)),
containerColor = MaterialTheme.colorScheme.tertiaryContainer, containerColor = MaterialTheme.colorScheme.tertiaryContainer,
) { ) {
Text( Text(

1
detekt-baselines/common.xml
View file

@ -3,7 +3,6 @@
<ManuallySuppressedIssues></ManuallySuppressedIssues> <ManuallySuppressedIssues></ManuallySuppressedIssues>
<CurrentIssues> <CurrentIssues>
<ID>MagicNumber:CommentEntry.kt$16</ID> <ID>MagicNumber:CommentEntry.kt$16</ID>
<ID>MagicNumber:LobstersCard.kt$8</ID>
<ID>MagicNumber:Theme.kt$31</ID> <ID>MagicNumber:Theme.kt$31</ID>
<ID>ModifierMissing:ClawAppBar.kt$ClawAppBarPreview</ID> <ID>ModifierMissing:ClawAppBar.kt$ClawAppBarPreview</ID>
<ID>ModifierReused:LobstersCard.kt$Row( modifier = modifier, verticalAlignment = Alignment.CenterVertically, horizontalArrangement = Arrangement.spacedBy(8.dp), ) { NetworkImage( url = avatarUrl, placeholder = ClawIcons.Account, contentDescription = contentDescription, modifier = modifier.requiredSize(24.dp).clip(CircleShape), ) Text(text = text, modifier = modifier, style = MaterialTheme.typography.bodyMedium) }</ID> <ID>ModifierReused:LobstersCard.kt$Row( modifier = modifier, verticalAlignment = Alignment.CenterVertically, horizontalArrangement = Arrangement.spacedBy(8.dp), ) { NetworkImage( url = avatarUrl, placeholder = ClawIcons.Account, contentDescription = contentDescription, modifier = modifier.requiredSize(24.dp).clip(CircleShape), ) Text(text = text, modifier = modifier, style = MaterialTheme.typography.bodyMedium) }</ID>