msfjarvis/compose-lobsters
1
Fork 0
mirror of https://github.com/msfjarvis/compose-lobsters synced 2025-08-14 22:17:03 +05:30
Code Issues Projects Releases Packages Wiki Activity Actions 4

Revert "fix(api): title and url are required for bookmark edits"

Browse source 
Seems to still fail in CI????????????????

This reverts commit cce12fb138.
This commit is contained in:
Harsh Shandilya 2023-10-28 00:34:07 +05:30
parent ab01554b82
commit 2273768556
No known key found for this signature in database
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
api/src/test/kotlin/dev/msfjarvis/claw/api/ShioriApiTest.kt
View file

@ -22,6 +22,7 @@ import org.junit.jupiter.api.AfterAll
import org.junit.jupiter.api.AfterEach import org.junit.jupiter.api.AfterEach
import org.junit.jupiter.api.BeforeAll import org.junit.jupiter.api.BeforeAll
import org.junit.jupiter.api.BeforeEach import org.junit.jupiter.api.BeforeEach
import org.junit.jupiter.api.Disabled
import org.junit.jupiter.api.Test import org.junit.jupiter.api.Test
import org.testcontainers.containers.GenericContainer import org.testcontainers.containers.GenericContainer
import retrofit2.Retrofit import retrofit2.Retrofit
@ -86,6 +87,7 @@ class ShioriApiTest {
} }
@Test @Test
@Disabled("Server returns HTTP 500, needs debugging")
fun editBookmark() = runTest { fun editBookmark() = runTest {
val response = val response =
api.addBookmark( api.addBookmark(
@ -107,8 +109,6 @@ class ShioriApiTest {
val newBookmark = val newBookmark =
EditedBookmark( EditedBookmark(
id = response.id, id = response.id,
url = response.url,
title = response.title,
tags = listOf(Tag("examples")), tags = listOf(Tag("examples")),
) )
val edited = api.editBookmark(credentials.session, newBookmark) val edited = api.editBookmark(credentials.session, newBookmark)

4
model/src/main/kotlin/dev/msfjarvis/claw/model/shiori/EditedBookmark.kt
View file

@ -13,8 +13,8 @@ import kotlinx.serialization.Serializable
@Poko @Poko
class EditedBookmark( class EditedBookmark(
val id: Int, val id: Int,
val url: String, val url: String? = null,
val title: String, val title: String? = null,
val excerpt: String? = null, val excerpt: String? = null,
val author: String? = null, val author: String? = null,
val public: Int? = null, val public: Int? = null,