msfjarvis/compose-lobsters
1
Fork 0
mirror of https://github.com/msfjarvis/compose-lobsters synced 2025-08-14 14:07:05 +05:30
Code Issues Projects Releases Packages Wiki Activity Actions 3

Apply suggestions from code review

Browse source
This commit is contained in:
Harsh Shandilya 2023-05-28 13:39:39 +05:30 • committed by GitHub
parent 78b77fd4c1
commit 5a098e125a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
android/src/main/kotlin/dev/msfjarvis/claw/android/ui/LobstersApp.kt
View file

@ -160,7 +160,7 @@ fun LobstersApp(
modifier = modifier.semantics { testTagsAsResourceId = true }, modifier = modifier.semantics { testTagsAsResourceId = true },
) { paddingValues -> ) { paddingValues ->
Row(modifier = Modifier.padding(paddingValues)) { Row(modifier = Modifier.padding(paddingValues)) {
AnimatedVisibility(visible = navigationType != ClawNavigationType.BOTTOM_NAVIGATION) { AnimatedVisibility(visible = navigationType == ClawNavigationType.NAVIGATION_RAIL) {
ClawNavigationRail( ClawNavigationRail(
navController = navController, navController = navController,
items = navItems, items = navItems,

1
android/src/main/kotlin/dev/msfjarvis/claw/android/ui/navigation/NavigationType.kt
View file

@ -15,7 +15,6 @@ enum class ClawNavigationType {
companion object { companion object {
fun fromSize(windowSize: WindowWidthSizeClass): ClawNavigationType { fun fromSize(windowSize: WindowWidthSizeClass): ClawNavigationType {
return when (windowSize) { return when (windowSize) {
WindowWidthSizeClass.Compact -> BOTTOM_NAVIGATION
WindowWidthSizeClass.Medium, WindowWidthSizeClass.Medium,
WindowWidthSizeClass.Expanded -> NAVIGATION_RAIL WindowWidthSizeClass.Expanded -> NAVIGATION_RAIL
else -> BOTTOM_NAVIGATION else -> BOTTOM_NAVIGATION