109: Misc cleanups r=msfjarvis a=msfjarvis

bors r+
🤖

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
This commit is contained in:
bors[bot] 2021-02-14 12:54:09 +00:00 committed by GitHub
commit 6fd45a2608
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 19 deletions

View file

@ -21,10 +21,6 @@ class LobstersRepository constructor(
return savedPostsCache.containsKey(postId) return savedPostsCache.containsKey(postId)
} }
fun getPostFromCache(postId: String): LobstersPost? {
return savedPostsCache[postId]
}
fun getAllPostsFromCache(): List<LobstersPost> { fun getAllPostsFromCache(): List<LobstersPost> {
return savedPostsCache.values.toList() return savedPostsCache.values.toList()
} }
@ -43,10 +39,6 @@ class LobstersRepository constructor(
_isCacheReady.value = true _isCacheReady.value = true
} }
private suspend fun getPost(postId: String): LobstersPost? = withContext(Dispatchers.IO) {
return@withContext lobstersDatabase.postQueries.selectPost(postId).executeAsOneOrNull()
}
private suspend fun getAllPosts(): List<LobstersPost> = withContext(Dispatchers.IO) { private suspend fun getAllPosts(): List<LobstersPost> = withContext(Dispatchers.IO) {
return@withContext lobstersDatabase.postQueries.selectAllPosts().executeAsList() return@withContext lobstersDatabase.postQueries.selectAllPosts().executeAsList()
} }

View file

@ -29,10 +29,10 @@ gradlePlugin {
} }
dependencies { dependencies {
implementation(Plugins.androidGradlePlugin) implementation(Plugins.android)
implementation(Plugins.androidGradlePlugin_lintModel) implementation(Plugins.hilt)
implementation(Plugins.daggerGradlePlugin)
implementation(Plugins.jsemver) implementation(Plugins.jsemver)
implementation(Plugins.kotlinGradlePlugin) implementation(Plugins.lintModel)
implementation(Plugins.sqldelightGradlePlugin) implementation(Plugins.kotlin)
implementation(Plugins.sqldelight)
} }

View file

@ -6,13 +6,12 @@
private const val DAGGER_HILT_VERSION = "2.32-alpha" private const val DAGGER_HILT_VERSION = "2.32-alpha"
object Plugins { object Plugins {
const val androidGradlePlugin = "com.android.tools.build:gradle:7.0.0-alpha06" const val android = "com.android.tools.build:gradle:7.0.0-alpha06"
const val androidGradlePlugin_lintModel = "com.android.tools.lint:lint-model:30.0.0-alpha06" const val lintModel = "com.android.tools.lint:lint-model:30.0.0-alpha06"
const val daggerGradlePlugin = const val hilt = "com.google.dagger:hilt-android-gradle-plugin:${DAGGER_HILT_VERSION}"
"com.google.dagger:hilt-android-gradle-plugin:${DAGGER_HILT_VERSION}" const val kotlin = "org.jetbrains.kotlin:kotlin-gradle-plugin:1.4.30"
const val kotlinGradlePlugin = "org.jetbrains.kotlin:kotlin-gradle-plugin:1.4.30"
const val jsemver = "com.github.zafarkhaja:java-semver:0.9.0" const val jsemver = "com.github.zafarkhaja:java-semver:0.9.0"
const val sqldelightGradlePlugin = "com.squareup.sqldelight:gradle-plugin:1.4.4" const val sqldelight = "com.squareup.sqldelight:gradle-plugin:1.4.4"
} }
object Dependencies { object Dependencies {