msfjarvis/compose-lobsters
1
Fork 0
mirror of https://github.com/msfjarvis/compose-lobsters synced 2025-08-14 22:17:03 +05:30
Code Issues Projects Releases Packages Wiki Activity Actions 4

chore: make LaunchedEffect keys consistent

Browse source
This commit is contained in:
Harsh Shandilya 2024-05-07 13:09:30 +05:30
parent 847858d852
commit 9fe6e34015
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
android/src/main/kotlin/dev/msfjarvis/claw/android/ui/screens/LobstersPostsScreen.kt
View file

@ -119,7 +119,7 @@ fun LobstersPostsScreen(
val navigationType = ClawNavigationType.fromSize(windowSizeClass.widthSizeClass) val navigationType = ClawNavigationType.fromSize(windowSizeClass.widthSizeClass)
val postIdOverride = context.getActivity()?.intent?.extras?.getString(MainActivity.NAVIGATION_KEY) val postIdOverride = context.getActivity()?.intent?.extras?.getString(MainActivity.NAVIGATION_KEY)
LaunchedEffect(false) { LaunchedEffect(Unit) {
if (postIdOverride != null) { if (postIdOverride != null) {
navController.navigate(Comments(postIdOverride)) navController.navigate(Comments(postIdOverride))
} }

2
common/src/main/kotlin/dev/msfjarvis/claw/common/ui/NetworkError.kt
View file

@ -30,7 +30,7 @@ import io.github.aakira.napier.Napier
@Composable @Composable
fun NetworkError(label: String, error: Throwable, modifier: Modifier = Modifier) { fun NetworkError(label: String, error: Throwable, modifier: Modifier = Modifier) {
LaunchedEffect(true) { Napier.e(error, "NetworkError") { "Failed to load posts" } } LaunchedEffect(Unit) { Napier.e(error, "NetworkError") { "Failed to load posts" } }
var showDialog by remember { mutableStateOf(false) } var showDialog by remember { mutableStateOf(false) }
Column(verticalArrangement = Arrangement.spacedBy(4.dp), modifier = modifier) { Column(verticalArrangement = Arrangement.spacedBy(4.dp), modifier = modifier) {
Text( Text(