fix(metadata-extractor): do not attempt extraction on HTTP URLs

These can pop up on lobste.rs rarely but Android only allows
us to do HTTPS, so the ideal solution is to just skip them and render
as-is.
This commit is contained in:
Harsh Shandilya 2022-09-10 16:42:14 +05:30
parent 8ced9d61d0
commit a19aa16924
No known key found for this signature in database

View file

@ -19,6 +19,7 @@ constructor(
suspend fun getExtractedMetadata(url: String): LinkMetadata { suspend fun getExtractedMetadata(url: String): LinkMetadata {
val parsedUrl = url.toHttpUrlOrNull() ?: return makeDefault(url) val parsedUrl = url.toHttpUrlOrNull() ?: return makeDefault(url)
if (!parsedUrl.isHttps) return makeDefault(url)
val request = Request.Builder().url(parsedUrl).build() val request = Request.Builder().url(parsedUrl).build()
val htmlContent = val htmlContent =
okHttpClient.newCall(request).execute().use { response -> okHttpClient.newCall(request).execute().use { response ->