msfjarvis/compose-lobsters
1
Fork 0
mirror of https://github.com/msfjarvis/compose-lobsters synced 2025-08-14 08:17:04 +05:30
Code Issues Projects Releases Packages Wiki Activity Actions 3

refactor(common): fix Modifier re-use

Browse source
This commit is contained in:
Harsh Shandilya 2022-10-03 22:39:44 +05:30
parent 069d7e5e05
commit a1ab32c43e
No known key found for this signature in database
2 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
common/src/main/kotlin/dev/msfjarvis/claw/common/posts/LobstersCard.kt
View file

@ -145,10 +145,10 @@ fun Submitter(
url = avatarUrl, url = avatarUrl,
placeholder = ClawIcons.Account, placeholder = ClawIcons.Account,
contentDescription = contentDescription, contentDescription = contentDescription,
modifier = modifier.requiredSize(24.dp).clip(CircleShape), modifier = Modifier.requiredSize(24.dp).clip(CircleShape),
) )
Text(text = text, modifier = modifier, style = MaterialTheme.typography.bodyMedium) Text(text = text, style = MaterialTheme.typography.bodyMedium)
} }
} }

2
detekt-baselines/common.xml
View file

@ -5,8 +5,6 @@
<ID>MagicNumber:CommentEntry.kt$16</ID> <ID>MagicNumber:CommentEntry.kt$16</ID>
<ID>MagicNumber:Theme.kt$31</ID> <ID>MagicNumber:Theme.kt$31</ID>
<ID>ModifierMissing:ClawAppBar.kt$ClawAppBarPreview</ID> <ID>ModifierMissing:ClawAppBar.kt$ClawAppBarPreview</ID>
<ID>ModifierReused:LobstersCard.kt$Row( modifier = modifier, verticalAlignment = Alignment.CenterVertically, horizontalArrangement = Arrangement.spacedBy(8.dp), ) { NetworkImage( url = avatarUrl, placeholder = ClawIcons.Account, contentDescription = contentDescription, modifier = modifier.requiredSize(24.dp).clip(CircleShape), ) Text(text = text, modifier = modifier, style = MaterialTheme.typography.bodyMedium) }</ID>
<ID>ModifierReused:LobstersCard.kt$Text(text = text, modifier = modifier, style = MaterialTheme.typography.bodyMedium)</ID>
<ID>SpreadOperator:Theme.kt$(*providedValues)</ID> <ID>SpreadOperator:Theme.kt$(*providedValues)</ID>
</CurrentIssues> </CurrentIssues>
</SmellBaseline> </SmellBaseline>