msfjarvis/compose-lobsters
1
Fork 0
mirror of https://github.com/msfjarvis/compose-lobsters synced 2025-08-14 18:47:03 +05:30
Code Issues Projects Releases Packages Wiki Activity Actions 4

refactor(common): ensure exceptions in UrlLauncher are logged

Browse source
This commit is contained in:
Harsh Shandilya 2022-10-03 11:58:41 +05:30
parent 38f1fdb6a3
commit d178bebebd
No known key found for this signature in database
2 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
common/src/main/kotlin/dev/msfjarvis/claw/common/urllauncher/UrlLauncher.kt
View file

@ -20,7 +20,7 @@ class UrlLauncher(private val context: Context) : UriHandler {
customTabsIntent.launchUrl(context, Uri.parse(uri)) customTabsIntent.launchUrl(context, Uri.parse(uri))
} catch (e: ActivityNotFoundException) { } catch (e: ActivityNotFoundException) {
val error = "Failed to open URL: $uri" val error = "Failed to open URL: $uri"
Napier.d(tag = "UrlLauncher") { error } Napier.d(throwable = e, tag = "UrlLauncher") { error }
Toast.makeText(context, error, Toast.LENGTH_SHORT).show() Toast.makeText(context, error, Toast.LENGTH_SHORT).show()
} }
} }

1
detekt-baselines/common.xml
View file

@ -12,7 +12,6 @@
<ID>ModifierReused:LobstersCard.kt$Row( modifier = modifier, verticalAlignment = Alignment.CenterVertically, horizontalArrangement = Arrangement.spacedBy(8.dp), ) { NetworkImage( url = avatarUrl, placeholder = ClawIcons.Account, contentDescription = contentDescription, modifier = modifier.requiredSize(24.dp).clip(CircleShape), ) Text(text = text, modifier = modifier, style = MaterialTheme.typography.bodyMedium) }</ID> <ID>ModifierReused:LobstersCard.kt$Row( modifier = modifier, verticalAlignment = Alignment.CenterVertically, horizontalArrangement = Arrangement.spacedBy(8.dp), ) { NetworkImage( url = avatarUrl, placeholder = ClawIcons.Account, contentDescription = contentDescription, modifier = modifier.requiredSize(24.dp).clip(CircleShape), ) Text(text = text, modifier = modifier, style = MaterialTheme.typography.bodyMedium) }</ID>
<ID>ModifierReused:LobstersCard.kt$Text(text = text, modifier = modifier, style = MaterialTheme.typography.bodyMedium)</ID> <ID>ModifierReused:LobstersCard.kt$Text(text = text, modifier = modifier, style = MaterialTheme.typography.bodyMedium)</ID>
<ID>SpreadOperator:Theme.kt$(*providedValues)</ID> <ID>SpreadOperator:Theme.kt$(*providedValues)</ID>
<ID>SwallowedException:UrlLauncher.kt$UrlLauncher$e: ActivityNotFoundException</ID>
<ID>ThrowingExceptionsWithoutMessageOrCause:NetworkError.kt$Throwable()</ID> <ID>ThrowingExceptionsWithoutMessageOrCause:NetworkError.kt$Throwable()</ID>
<ID>UnnecessaryAbstractClass:BasePaparazziTest.kt$BasePaparazziTest$BasePaparazziTest</ID> <ID>UnnecessaryAbstractClass:BasePaparazziTest.kt$BasePaparazziTest$BasePaparazziTest</ID>
</CurrentIssues> </CurrentIssues>