msfjarvis/compose-lobsters
1
Fork 0
mirror of https://github.com/msfjarvis/compose-lobsters synced 2025-08-17 21:27:01 +05:30
Code Issues Projects Releases Packages Wiki Activity Actions

Merge #156

Browse source 
156: Fix scroll crash r=msfjarvis a=msfjarvis

Fixes #155
bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
This commit is contained in:
bors[bot] 2021-03-15 17:17:29 +00:00 • committed by GitHub
commit ddc504eb05
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
.idea/artifacts/common_jvm.xml generated
View file

@ -1,6 +1,8 @@
<component name="ArtifactManager"> <component name="ArtifactManager">
<artifact type="jar" name="common-jvm"> <artifact type="jar" name="common-jvm">
<output-path>$PROJECT_DIR$/common/build/libs</output-path> <output-path>$PROJECT_DIR$/common/build/libs</output-path>
<root id="archive" name="common-jvm.jar" /> <root id="archive" name="common-jvm.jar">
<element id="module-output" name="Claw.common.jvmMain" />
</root>
</artifact> </artifact>
</component> </component>

5
app/src/main/java/dev/msfjarvis/lobsters/ui/main/LobstersApp.kt
View file

@ -20,6 +20,7 @@ import androidx.navigation.compose.composable
import androidx.navigation.compose.currentBackStackEntryAsState import androidx.navigation.compose.currentBackStackEntryAsState
import androidx.navigation.compose.navigate import androidx.navigation.compose.navigate
import androidx.navigation.compose.rememberNavController import androidx.navigation.compose.rememberNavController
import androidx.paging.LoadState
import androidx.paging.compose.collectAsLazyPagingItems import androidx.paging.compose.collectAsLazyPagingItems
import dev.msfjarvis.lobsters.ui.navigation.Destination import dev.msfjarvis.lobsters.ui.navigation.Destination
import dev.msfjarvis.lobsters.ui.posts.HottestPosts import dev.msfjarvis.lobsters.ui.posts.HottestPosts
@ -47,7 +48,9 @@ fun LobstersApp() {
} }
} }
val jumpToIndex: suspend (Int) -> Unit = { val jumpToIndex: suspend (Int) -> Unit = {
hottestPostsListState.animateScrollToItem(it) if (hottestPosts.loadState.refresh != LoadState.Loading) {
hottestPostsListState.animateScrollToItem(it)
}
} }
Scaffold( Scaffold(

3
gradle.properties
View file

@ -48,3 +48,6 @@ android.defaults.buildfeatures.renderscript=false
android.defaults.buildfeatures.resvalues=false android.defaults.buildfeatures.resvalues=false
android.defaults.buildfeatures.shaders=false android.defaults.buildfeatures.shaders=false
android.library.defaults.buildfeatures.androidresources=false android.library.defaults.buildfeatures.androidresources=false
# Disable KMP warning
kotlin.mpp.stability.nowarn=true